From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757514AbdKOKTa (ORCPT ); Wed, 15 Nov 2017 05:19:30 -0500 Received: from mail.sigma-star.at ([95.130.255.111]:45996 "EHLO mail.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756448AbdKOKTY (ORCPT ); Wed, 15 Nov 2017 05:19:24 -0500 From: Richard Weinberger To: Krzysztof Mazur Cc: Jeff Dike , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, user-mode-linux-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] um: use POSIX ucontext_t instead of struct ucontext Date: Wed, 15 Nov 2017 11:19:41 +0100 Message-ID: <1518438.KRCSCszYuI@blindfold> In-Reply-To: <20171115101239.4882-1-krzysiek@podlesie.net> References: <20171115101239.4882-1-krzysiek@podlesie.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 15. November 2017, 11:12:39 CET schrieb Krzysztof Mazur: > glibc 2.26 removed the 'struct ucontext' to "improve" POSIX compliance > and break programs, including User Mode Linux. Fix User Mode Linux > by using POSIX ucontext_t. > > This fixes: > > arch/um/os-Linux/signal.c: In function 'hard_handler': > arch/um/os-Linux/signal.c:163:22: error: dereferencing pointer to incomplete > type 'struct ucontext' mcontext_t *mc = &uc->uc_mcontext; > arch/x86/um/stub_segv.c: In function 'stub_segv_handler': > arch/x86/um/stub_segv.c:16:13: error: dereferencing pointer to incomplete > type 'struct ucontext' &uc->uc_mcontext); Do all older glibcs have ucontext_t? Otherwise this patch will break other stuff. Thanks, //richard