From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org
Cc: mhiramat@kernel.org, Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-trace-users@vger.kernel.org
Subject: [RFC PATCH 3/8] tracing: probeevent: Remove NOKPROBE_SYMBOL from print functions
Date: Wed, 14 Feb 2018 00:37:13 +0900 [thread overview]
Message-ID: <151853623330.31487.6413884532341147140.stgit@devbox> (raw)
In-Reply-To: <151853614489.31487.10683006682475678487.stgit@devbox>
Remove unneeded NOKPROBE_SYMBOL from print functions since
the print functions are only used when printing out the
trace data, and not from kprobe handler.
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
kernel/trace/trace_probe.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
index 157cfdfa8430..be98a58416a9 100644
--- a/kernel/trace/trace_probe.c
+++ b/kernel/trace/trace_probe.c
@@ -43,8 +43,7 @@ int PRINT_TYPE_FUNC_NAME(tname)(struct trace_seq *s, void *data, void *ent)\
trace_seq_printf(s, fmt, *(type *)data); \
return !trace_seq_has_overflowed(s); \
} \
-const char PRINT_TYPE_FMT_NAME(tname)[] = fmt; \
-NOKPROBE_SYMBOL(PRINT_TYPE_FUNC_NAME(tname));
+const char PRINT_TYPE_FMT_NAME(tname)[] = fmt;
DEFINE_BASIC_PRINT_TYPE_FUNC(u8, u8, "%u")
DEFINE_BASIC_PRINT_TYPE_FUNC(u16, u16, "%u")
@@ -71,7 +70,6 @@ int PRINT_TYPE_FUNC_NAME(string)(struct trace_seq *s, void *data, void *ent)
(const char *)get_loc_data(data, ent));
return !trace_seq_has_overflowed(s);
}
-NOKPROBE_SYMBOL(PRINT_TYPE_FUNC_NAME(string));
const char PRINT_TYPE_FMT_NAME(string)[] = "\\\"%s\\\"";
next prev parent reply other threads:[~2018-02-13 15:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 15:35 [RFC PATCH 0/8] tracing: probeevent: Improve fetcharg features Masami Hiramatsu
2018-02-13 15:36 ` [RFC PATCH 1/8] tracing: probeevent: Cleanup print argument functions Masami Hiramatsu
2018-02-13 15:36 ` [RFC PATCH 2/8] tracing: probeevent: Cleanup argument field definition Masami Hiramatsu
2018-02-13 15:37 ` Masami Hiramatsu [this message]
2018-02-13 15:37 ` [RFC PATCH 4/8] tracing: probeevent: Introduce new argument fetching code Masami Hiramatsu
2018-02-13 15:38 ` [RFC PATCH 5/8] tracing: probeevent: Add symbol type Masami Hiramatsu
2018-02-13 15:38 ` [RFC PATCH 6/8] x86: ptrace: Add function argument access API Masami Hiramatsu
2018-02-13 15:39 ` [RFC PATCH 7/8] tracing: probeevent: Add $argN for accessing function args Masami Hiramatsu
2018-02-13 15:39 ` [RFC PATCH 8/8] tracing: probeevent: Add an array for basic types Masami Hiramatsu
2018-02-13 15:58 ` [RFC PATCH 0/8] tracing: probeevent: Improve fetcharg features Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151853623330.31487.6413884532341147140.stgit@devbox \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox