public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"tvrtko.ursulin@intel.com" <tvrtko.ursulin@intel.com>,
	"jthumshirn@suse.de" <jthumshirn@suse.de>,
	"khandual@linux.vnet.ibm.com" <khandual@linux.vnet.ibm.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH] lib/scatterlist: Add SG_CHAIN and SG_EMARK macros for LSB encodings
Date: Wed, 14 Feb 2018 16:03:49 +0000	[thread overview]
Message-ID: <1518624228.3147.4.camel@wdc.com> (raw)
In-Reply-To: <20180214045804.9113-1-khandual@linux.vnet.ibm.com>

On Wed, 2018-02-14 at 10:28 +0530, Anshuman Khandual wrote:
> +#define SG_CHAIN	0x01
> +#define SG_EMARK	0x02

Hello Anshuman,

As you probably know constants that do not have a suffix are of type int. Please
consider to add suffix "UL" to these constants to avoid that the compiler could
take an undesired decision when e.g. converting ~SG_CHAIN from int to unsigned
long.

Thanks,

Bart.

  parent reply	other threads:[~2018-02-14 16:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14  4:58 [PATCH] lib/scatterlist: Add SG_CHAIN and SG_EMARK macros for LSB encodings Anshuman Khandual
2018-02-14  8:32 ` Johannes Thumshirn
2018-02-14 16:11   ` Tvrtko Ursulin
2018-02-15  2:53     ` Anshuman Khandual
2018-02-14 16:03 ` Bart Van Assche [this message]
2018-02-15  2:54   ` Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1518624228.3147.4.camel@wdc.com \
    --to=bart.vanassche@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=chris@chris-wilson.co.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=jthumshirn@suse.de \
    --cc=khandual@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tvrtko.ursulin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox