From: Luciano Coelho <luciano.coelho@intel.com>
To: Ulf Magnusson <ulfalizer@gmail.com>, linux-kernel@vger.kernel.org
Cc: linux-kbuild@vger.kernel.org, tfiga@chromium.org,
paul.burton@mips.com, m.szyprowski@samsung.com,
egtvedt@samfundet.no, linus.walleij@linaro.org,
vgupta@synopsys.com, mgorman@techsingularity.net, hch@lst.de,
mina86@mina86.com, robh@kernel.org, sboyd@codeaurora.org,
paulus@ozlabs.org, will.deacon@arm.com, tony@atomide.com,
npiggin@gmail.com, yamada.masahiro@socionext.com,
Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Intel Linux Wireless <linuxwifi@intel.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 18/20] iwlwifi: fix malformed CONFIG_IWLWIFI_PCIE_RTPM default
Date: Thu, 15 Feb 2018 09:35:51 +0200 [thread overview]
Message-ID: <1518680151.7832.26.camel@intel.com> (raw)
In-Reply-To: <20180205012146.23981-19-ulfalizer@gmail.com>
On Mon, 2018-02-05 at 02:21 +0100, Ulf Magnusson wrote:
> 'default false' should be 'default n', though they happen to have the
> same effect here, due to undefined symbols ('false' in this case)
> evaluating to n in a tristate sense.
>
> Remove the default instead of changing it. bool and tristate symbols
> implicitly default to n.
>
> Discovered with the
> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_und
> efined.py
> script.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---
Thanks, Ulf!
This is applied in our internal tree and will eventually reach the
mainline, following our usual upstreaming process.
--
Cheers,
Luca.
next prev parent reply other threads:[~2018-02-15 7:36 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 1:21 [PATCH 00/20] Remove references to undefined symbols and fix two potential bugs Ulf Magnusson
2018-02-05 1:21 ` [PATCH 01/20] ARM: mvebu: Fix broken PL310_ERRATA_753970 selects Ulf Magnusson
2018-02-13 15:43 ` Gregory CLEMENT
2018-02-05 1:21 ` [PATCH 02/20] KVM: PPC: Book3S PR: Fix broken select due to misspelling Ulf Magnusson
2018-02-05 4:48 ` Paul Mackerras
2018-02-05 4:58 ` Ulf Magnusson
2018-02-05 7:56 ` Paul Mackerras
2018-02-05 1:21 ` [PATCH 03/20] kconfig: Remove leftover references to AVR32 symbol Ulf Magnusson
2018-02-05 4:05 ` Viresh Kumar
2018-02-05 4:44 ` [PATCH v2 " Ulf Magnusson
2018-02-05 1:21 ` [PATCH 04/20] misc: atmel: Remove CPU_AT32AP700X (AVR32) reference Ulf Magnusson
2018-02-05 1:21 ` [PATCH 05/20] rtc: at32ap700x: Remove PLATFORM_AT32AP dependency Ulf Magnusson
2018-02-05 1:42 ` Ulf Magnusson
2018-02-05 14:01 ` Alexandre Belloni
2018-02-05 20:31 ` Ulf Magnusson
2018-02-05 1:21 ` [PATCH 06/20] riscv: Remove ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE select Ulf Magnusson
2018-02-05 10:45 ` Jonathan Neuschäfer
2018-02-08 18:34 ` Palmer Dabbelt
2018-02-08 22:10 ` Ulf Magnusson
2018-02-05 1:21 ` [PATCH 07/20] riscv: Remove ARCH_WANT_OPTIONAL_GPIOLIB select Ulf Magnusson
2018-02-05 1:30 ` Ulf Magnusson
2018-02-08 20:51 ` Palmer Dabbelt
2018-02-08 22:54 ` [PATCH] riscv: kconfig: Remove RISCV_IRQ_INTC select Ulf Magnusson
2018-02-13 2:07 ` Palmer Dabbelt
2018-02-05 23:25 ` [PATCH 07/20] riscv: Remove ARCH_WANT_OPTIONAL_GPIOLIB select Linus Walleij
2018-02-05 23:38 ` Ulf Magnusson
2018-02-05 23:49 ` Ulf Magnusson
2018-02-06 9:49 ` Linus Walleij
2018-02-06 9:47 ` Linus Walleij
2018-02-08 22:58 ` Palmer Dabbelt
2018-02-08 18:34 ` Palmer Dabbelt
2018-02-08 22:56 ` Ulf Magnusson
2018-02-05 1:21 ` [PATCH 08/20] s390/kconfig: Remove ARCH_WANTS_PROT_NUMA_PROT_NONE select Ulf Magnusson
2018-02-05 6:56 ` Heiko Carstens
2018-02-05 1:21 ` [PATCH 09/20] clk: sunxi-ng: Remove SUNXI_CCU_* selects Ulf Magnusson
2018-02-05 13:46 ` Maxime Ripard
2018-02-05 1:21 ` [PATCH 10/20] lib/Kconfig: Remove leftover select of GENERIC_IO Ulf Magnusson
2018-02-06 16:08 ` Rob Herring
2018-02-06 16:16 ` Robin Murphy
2018-02-19 15:48 ` Rob Herring
2018-02-19 17:03 ` Ulf Magnusson
2018-02-05 1:21 ` [PATCH 11/20] usb: gadget: udc: Remove USB_GADGET_DUALSPEED select Ulf Magnusson
2018-02-05 1:21 ` [PATCH 12/20] ARM: debug: Remove ARCH_MSM dep. from UNCOMPRESS_INCLUDE Ulf Magnusson
2018-02-05 1:46 ` Ulf Magnusson
2018-02-05 1:21 ` [PATCH 13/20] ore: Remove PNFS_OBJLAYOUT dependency Ulf Magnusson
2018-02-05 1:21 ` [PATCH 14/20] iio: gyro: mpu3050: Remove INPUT_MPU3050 dep. from I2C Ulf Magnusson
2018-02-07 12:10 ` Linus Walleij
2018-02-05 1:21 ` [PATCH 15/20] phy: Remove SOC_EXYNOS4212 dep. from PHY_EXYNOS4X12_USB Ulf Magnusson
2018-02-05 8:00 ` Krzysztof Kozlowski
2018-02-16 11:52 ` Kishon Vijay Abraham I
2018-02-05 1:21 ` [PATCH 16/20] auxdisplay: img-ascii-lcd: Remove MIPS_SEAD3 dep Ulf Magnusson
2018-02-05 1:58 ` Ulf Magnusson
2018-02-06 18:09 ` Randy Dunlap
2018-02-08 15:37 ` Miguel Ojeda
2018-02-10 14:14 ` [PATCH v2] auxdisplay: img-ascii-lcd: kconfig: Remove MIPS_SEAD3 reference Ulf Magnusson
2018-02-11 16:40 ` Miguel Ojeda
2018-02-12 13:51 ` Miguel Ojeda
2018-02-08 17:35 ` [PATCH 16/20] auxdisplay: img-ascii-lcd: Remove MIPS_SEAD3 dep James Hogan
2018-02-10 14:19 ` Ulf Magnusson
2018-02-05 1:21 ` [PATCH 17/20] media: sec: Remove PLAT_S5P dependency Ulf Magnusson
2018-02-05 1:21 ` [PATCH 18/20] iwlwifi: fix malformed CONFIG_IWLWIFI_PCIE_RTPM default Ulf Magnusson
2018-02-15 7:35 ` Luciano Coelho [this message]
2018-02-05 1:21 ` [PATCH 19/20] ARC: Fix malformed ARC_EMUL_UNALIGNED default Ulf Magnusson
2018-02-05 17:17 ` Vineet Gupta
2018-02-05 1:21 ` [PATCH 20/20] x86/PCI: VMD: Fix malformed default Ulf Magnusson
2018-02-05 2:03 ` Ulf Magnusson
2018-02-06 19:11 ` Bjorn Helgaas
2018-02-06 22:17 ` Ulf Magnusson
2018-02-05 1:37 ` [PATCH 00/20] Remove references to undefined symbols and fix two potential bugs Ulf Magnusson
2018-02-05 1:52 ` Ulf Magnusson
2018-02-05 2:08 ` Ulf Magnusson
2018-02-07 9:28 ` Robert Jarzmik
2018-02-08 23:15 ` [PATCH] ALSA: ac97: kconfig: Remove select of undefined symbol AC97 Ulf Magnusson
2018-02-08 23:20 ` Ulf Magnusson
2018-02-12 7:17 ` Takashi Iwai
2018-02-05 4:15 ` [PATCH 00/20] Remove references to undefined symbols and fix two potential bugs Ulf Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518680151.7832.26.camel@intel.com \
--to=luciano.coelho@intel.com \
--cc=egtvedt@samfundet.no \
--cc=emmanuel.grumbach@intel.com \
--cc=hch@lst.de \
--cc=johannes.berg@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@techsingularity.net \
--cc=mina86@mina86.com \
--cc=netdev@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=paul.burton@mips.com \
--cc=paulus@ozlabs.org \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=tfiga@chromium.org \
--cc=tony@atomide.com \
--cc=ulfalizer@gmail.com \
--cc=vgupta@synopsys.com \
--cc=will.deacon@arm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).