* [PATCH] Revert "gpio: winbond: fix ISA_BUS_API dependency"
@ 2018-02-23 14:55 Maciej S. Szmigiero
2018-02-23 15:19 ` Arnd Bergmann
2018-02-26 10:28 ` Linus Walleij
0 siblings, 2 replies; 5+ messages in thread
From: Maciej S. Szmigiero @ 2018-02-23 14:55 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-kernel, William Breathitt Gray, Guenter Roeck, linux-gpio,
Arnd Bergmann, Andy Shevchenko
This reverts commit 92a8046c9d952a2a7d21dfcd3afadc72a0bc0f72.
Now that the patch series changing ISA_BUS_API dependency to selection
was merged this reversion will do the same for gpio-winbond driver to
make it consistent with other ISA bus gpio drivers.
Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
---
drivers/gpio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index dff99871bca8..6d481ef03623 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -722,7 +722,7 @@ config GPIO_TS5500
config GPIO_WINBOND
tristate "Winbond Super I/O GPIO support"
- depends on ISA_BUS_API
+ select ISA_BUS_API
help
This option enables support for GPIOs found on Winbond Super I/O
chips.
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "gpio: winbond: fix ISA_BUS_API dependency"
2018-02-23 14:55 [PATCH] Revert "gpio: winbond: fix ISA_BUS_API dependency" Maciej S. Szmigiero
@ 2018-02-23 15:19 ` Arnd Bergmann
2018-02-23 15:20 ` Andy Shevchenko
2018-02-23 15:25 ` William Breathitt Gray
2018-02-26 10:28 ` Linus Walleij
1 sibling, 2 replies; 5+ messages in thread
From: Arnd Bergmann @ 2018-02-23 15:19 UTC (permalink / raw)
To: Maciej S. Szmigiero
Cc: Linus Walleij, linux-kernel, William Breathitt Gray,
Guenter Roeck, linux-gpio, Andy Shevchenko
On Fri, Feb 23, 2018 at 3:55 PM, Maciej S. Szmigiero
<mail@maciej.szmigiero.name> wrote:
> This reverts commit 92a8046c9d952a2a7d21dfcd3afadc72a0bc0f72.
>
> Now that the patch series changing ISA_BUS_API dependency to selection
> was merged this reversion will do the same for gpio-winbond driver to
> make it consistent with other ISA bus gpio drivers.
>
> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
I still see a number of other users of 'depends on ISA_BUS_API' in linux-next:
drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API
drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API
drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API
drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API
drivers/gpio/Kconfig: depends on ISA_BUS_API
drivers/gpio/Kconfig: depends on ISA_BUS_API
drivers/iio/adc/Kconfig: depends on PC104 && X86 && ISA_BUS_API
drivers/iio/counter/Kconfig: depends on PC104 && X86 && ISA_BUS_API
drivers/iio/dac/Kconfig: depends on X86 && ISA_BUS_API
drivers/watchdog/Kconfig: depends on X86 && ISA_BUS_API
Did you change all of the above? I would really like to avoid mixing
'select' and 'depends on' here, as that will likely cause other circular
dependencies in the future.
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Revert "gpio: winbond: fix ISA_BUS_API dependency"
2018-02-23 15:19 ` Arnd Bergmann
@ 2018-02-23 15:20 ` Andy Shevchenko
2018-02-23 15:25 ` William Breathitt Gray
1 sibling, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2018-02-23 15:20 UTC (permalink / raw)
To: Arnd Bergmann, Maciej S. Szmigiero
Cc: Linus Walleij, linux-kernel, William Breathitt Gray,
Guenter Roeck, linux-gpio
On Fri, 2018-02-23 at 16:19 +0100, Arnd Bergmann wrote:
> On Fri, Feb 23, 2018 at 3:55 PM, Maciej S. Szmigiero
> <mail@maciej.szmigiero.name> wrote:
> I would really like to avoid mixing
> 'select' and 'depends on' here, as that will likely cause other
> circular
> dependencies in the future.
Agree. And it doesn't make sense to do in a separate changes.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "gpio: winbond: fix ISA_BUS_API dependency"
2018-02-23 15:19 ` Arnd Bergmann
2018-02-23 15:20 ` Andy Shevchenko
@ 2018-02-23 15:25 ` William Breathitt Gray
1 sibling, 0 replies; 5+ messages in thread
From: William Breathitt Gray @ 2018-02-23 15:25 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Maciej S. Szmigiero, Linus Walleij, linux-kernel, Guenter Roeck,
linux-gpio, Andy Shevchenko
On Fri, Feb 23, 2018 at 04:19:01PM +0100, Arnd Bergmann wrote:
>On Fri, Feb 23, 2018 at 3:55 PM, Maciej S. Szmigiero
><mail@maciej.szmigiero.name> wrote:
>> This reverts commit 92a8046c9d952a2a7d21dfcd3afadc72a0bc0f72.
>>
>> Now that the patch series changing ISA_BUS_API dependency to selection
>> was merged this reversion will do the same for gpio-winbond driver to
>> make it consistent with other ISA bus gpio drivers.
>>
>> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
>
>I still see a number of other users of 'depends on ISA_BUS_API' in linux-next:
>
>drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API
>drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API
>drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API
>drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API
>drivers/gpio/Kconfig: depends on ISA_BUS_API
>drivers/gpio/Kconfig: depends on ISA_BUS_API
>drivers/iio/adc/Kconfig: depends on PC104 && X86 && ISA_BUS_API
>drivers/iio/counter/Kconfig: depends on PC104 && X86 && ISA_BUS_API
>drivers/iio/dac/Kconfig: depends on X86 && ISA_BUS_API
>drivers/watchdog/Kconfig: depends on X86 && ISA_BUS_API
>
>Did you change all of the above? I would really like to avoid mixing
>'select' and 'depends on' here, as that will likely cause other circular
>dependencies in the future.
>
> Arnd
Those 'depends on' for ISA_BUS_API are resolved in the devel branch of
the linux-gpio tree; this revert patch should be applied there before
being picked up later for linux-next.
William Breathitt Gray
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "gpio: winbond: fix ISA_BUS_API dependency"
2018-02-23 14:55 [PATCH] Revert "gpio: winbond: fix ISA_BUS_API dependency" Maciej S. Szmigiero
2018-02-23 15:19 ` Arnd Bergmann
@ 2018-02-26 10:28 ` Linus Walleij
1 sibling, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2018-02-26 10:28 UTC (permalink / raw)
To: Maciej S. Szmigiero
Cc: linux-kernel, William Breathitt Gray, Guenter Roeck,
open list:GPIO SUBSYSTEM, Arnd Bergmann, Andy Shevchenko
On Fri, Feb 23, 2018 at 3:55 PM, Maciej S. Szmigiero
<mail@maciej.szmigiero.name> wrote:
> This reverts commit 92a8046c9d952a2a7d21dfcd3afadc72a0bc0f72.
>
> Now that the patch series changing ISA_BUS_API dependency to selection
> was merged this reversion will do the same for gpio-winbond driver to
> make it consistent with other ISA bus gpio drivers.
>
> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-26 10:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-23 14:55 [PATCH] Revert "gpio: winbond: fix ISA_BUS_API dependency" Maciej S. Szmigiero
2018-02-23 15:19 ` Arnd Bergmann
2018-02-23 15:20 ` Andy Shevchenko
2018-02-23 15:25 ` William Breathitt Gray
2018-02-26 10:28 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox