From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751682AbeBZRg6 (ORCPT ); Mon, 26 Feb 2018 12:36:58 -0500 Received: from smtp-fw-9102.amazon.com ([207.171.184.29]:21815 "EHLO smtp-fw-9102.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751604AbeBZRgz (ORCPT ); Mon, 26 Feb 2018 12:36:55 -0500 X-IronPort-AV: E=Sophos;i="5.47,397,1515456000"; d="scan'208";a="596814924" From: Amit Shah To: CC: , Amit Shah , , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , David Vrabel , "Boris Ostrovsky" , Eduardo Valentin , Juergen Gross , Thomas Gleixner , "K. Y. Srinivasan" , Liu Shuo , Anoob Soman Subject: [PATCH 1/2] xen: fix out-of-bounds irq unbind for MSI message groups Date: Mon, 26 Feb 2018 17:36:34 +0000 Message-ID: <1519666595-41362-2-git-send-email-aams@amazon.com> X-Mailer: git-send-email 2.7.3.AMZN In-Reply-To: <1519666595-41362-1-git-send-email-aams@amazon.com> References: <1519666595-41362-1-git-send-email-aams@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w1QHb4Rs003023 When an MSI descriptor was not available, the error path would try to unbind an irq that was never acquired - potentially unbinding an unrelated irq. Fixes: 4892c9b4ada9f9 ("xen: add support for MSI message groups") Reported-by: Hooman Mirhadi CC: CC: Roger Pau Monné CC: David Vrabel CC: Boris Ostrovsky CC: Eduardo Valentin CC: Juergen Gross CC: Thomas Gleixner CC: "K. Y. Srinivasan" CC: Liu Shuo CC: Anoob Soman Signed-off-by: Amit Shah --- drivers/xen/events/events_base.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c index 1ab4bd1..b6b8b29 100644 --- a/drivers/xen/events/events_base.c +++ b/drivers/xen/events/events_base.c @@ -749,6 +749,7 @@ int xen_bind_pirq_msi_to_irq(struct pci_dev *dev, struct msi_desc *msidesc, } ret = irq_set_msi_desc(irq, msidesc); + i--; if (ret < 0) goto error_irq; out: -- 2.7.3.AMZN Amazon Development Center Germany GmbH Berlin - Dresden - Aachen main office: Krausenstr. 38, 10117 Berlin Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger Ust-ID: DE289237879 Eingetragen am Amtsgericht Charlottenburg HRB 149173 B