From: Sebastian Panceac <sebastian@resin.io>
To: andy.shevchenko@gmail.com
Cc: Sebastian Panceac <sebastian@resin.io>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] x86: Fix Intel Edison module stuck reboot
Date: Tue, 27 Feb 2018 12:07:00 +0200 [thread overview]
Message-ID: <1519726020-24442-1-git-send-email-sebastian@resin.io> (raw)
In-Reply-To: <CAHp75VfEc0a_Fff1znWVos3rPzCGsvGLGX7NgH_bH96egree7A@mail.gmail.com>
Hi Andy,
I fixed the commit description according to your suggestions and used git send-email.
Regards!
When powering Intel Edison module with 3.3V,
the "reboot" command makes the module stuck.
If the module is powered at a greater voltage,
like 4.4V(as the Edison Mini Breakout board does), reboot works OK.
This patch copies the behaviour from the official Intel Edison BSP,
where "IPCMSG_COLD_RESET" message
was sent to SCU by default at reboot time.
In the official BSP, sending the "IPCMSG_COLD_BOOT" message instead
of "IPCMSG_COLD_RESET" was possible,
by using a kernel command line parameter.
Signed-off-by: Sebastian Panceac <sebastian@resin.io>
---
arch/x86/platform/intel-mid/intel-mid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/platform/intel-mid/intel-mid.c b/arch/x86/platform/intel-mid/intel-mid.c
index 2c67bae..fb1df94 100644
--- a/arch/x86/platform/intel-mid/intel-mid.c
+++ b/arch/x86/platform/intel-mid/intel-mid.c
@@ -79,7 +79,7 @@ static void intel_mid_power_off(void)
static void intel_mid_reboot(void)
{
- intel_scu_ipc_simple_command(IPCMSG_COLD_BOOT, 0);
+ intel_scu_ipc_simple_command(IPCMSG_COLD_RESET, 0);
}
static unsigned long __init intel_mid_calibrate_tsc(void)
--
2.7.4
next prev parent reply other threads:[~2018-02-27 10:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CANoH8WgoPbhh+OS-HQD5uk3xbedrqHnwufJ9Bj4hSEuuTBkapw@mail.gmail.com>
2018-02-22 17:33 ` [PATCH 1/1] x86: Fix Intel Edison module stuck reboot Andy Shevchenko
2018-02-27 10:07 ` Sebastian Panceac [this message]
2018-02-27 15:44 ` Andy Shevchenko
2018-02-28 9:40 ` [PATCH v3 " Sebastian Panceac
2018-02-28 10:47 ` Andy Shevchenko
2018-02-28 17:21 ` [tip:x86/urgent] x86/platform/intel-mid: Handle Intel Edison reboot correctly tip-bot for Sebastian Panceac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519726020-24442-1-git-send-email-sebastian@resin.io \
--to=sebastian@resin.io \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).