From: Johannes Thumshirn <jthumshirn@suse.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Michael Moese <mmoese@suse.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Eli Billauer <eli.billauer@gmail.com>,
Anatolij Gustschin <agust@denx.de>
Subject: Re: [PATCH 1/2] PCI: add vendor id for Altera
Date: Tue, 27 Feb 2018 16:42:07 +0100 [thread overview]
Message-ID: <1519746127.25526.25.camel@suse.de> (raw)
In-Reply-To: <CAHp75VdwHZxCzppayKaLdGJ++QKTKnZWwfHXOJ_bhMVHOJCu1A@mail.gmail.com>
On Tue, 2018-02-27 at 17:32 +0200, Andy Shevchenko wrote:
> On Tue, Feb 27, 2018 at 3:30 PM, Johannes Thumshirn <jthumshirn@suse.de>
> wrote:
> >
> > Add the Altera PCI Vendor id to pci_ids.h and remove the private
> > definitions from xillybus_pcie.c and altera-cvp.c.
>
> >
> > #include <linux/pci.h>
> > +#include <linux/pci_ids.h>
>
> >
> > #include <linux/pci.h>
> > +#include <linux/pci_ids.h>
>
> Isn't pci.h includes pci_ids.h ?
It indeed is, but it won't do any harm and it's not quite clear what the
general policy (regarding pci_ids.h) is, some drivers include it (even in
the drivers/pci/) some don't.
Bjorn, any guidance from your side?
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumshi
rn@suse.de +49 911 74053 689
SUSE LINUX GmbH,
Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham
Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600
D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2018-02-27 15:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 13:30 [PATCH 0/2] MCB Update for v4.17 Johannes Thumshirn
2018-02-27 13:30 ` [PATCH 1/2] PCI: add vendor id for Altera Johannes Thumshirn
2018-02-27 15:32 ` Andy Shevchenko
2018-02-27 15:42 ` Johannes Thumshirn [this message]
2018-02-27 17:39 ` Bjorn Helgaas
2018-02-27 19:52 ` Eli Billauer
2018-02-27 13:30 ` [PATCH 2/2] mcb: add Altera PCI ID to mcb-pci Johannes Thumshirn
2018-02-27 13:37 ` Michael Moese
2018-02-27 15:33 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519746127.25526.25.camel@suse.de \
--to=jthumshirn@suse.de \
--cc=agust@denx.de \
--cc=andy.shevchenko@gmail.com \
--cc=bhelgaas@google.com \
--cc=eli.billauer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmoese@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox