From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org
Cc: mhiramat@kernel.org, Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-trace-users@vger.kernel.org,
linux-kselftest@vger.kernel.org, shuah@kernel.org
Subject: [PATCH v4 00/19] tracing: probeevent: Improve fetcharg features
Date: Wed, 28 Feb 2018 12:19:23 +0900 [thread overview]
Message-ID: <151978796240.2577.6531711990653677529.stgit@devbox> (raw)
Hi,
This is the 4th version of the fetch-arg improvement series.
This includes variable changes on fetcharg framework like,
- Add fetcharg testcases (syntax, argN, symbol, string and array)
and probepoint testcase.
- Rewrite fetcharg framework with fetch_insn, switch-case based
instead of function pointer.
- Add "symbol" type support, which shows symbol+offset instead of
address value.
- Add "$argN" fetcharg, which fetches function parameters.
(currently only for x86-64)
- Add array type support (including string arrary :) ) ,
which enables to get fixed length array from probe-events.
V3 is here:
https://lkml.org/lkml/2018/2/24/3
Changes from the v3 are here:
- [1/19] Fix to pass a sign to kstrtol (Thanks Namhyung!)
and check UINT_MAX for kprobe's offset.
- [4/19] Add new testcase for checking probepoint syntax.
- [16/19] Fix to use calculated size correctly for field definition.
(Thank you Namhyung!).
- [19/19] Add format field tests.
Here are examples:
o 'symbol' type
# echo 'p vfs_read $stack0:symbol' > kprobe_events
# echo 1 > events/kprobes/p_vfs_read_0/enable
# tail -n 3 trace
sh-729 [007] ...2 105.753637: p_vfs_read_0: (vfs_read+0x0/0x130) arg1=SyS_read+0x42/0x90
tail-736 [000] ...2 105.754904: p_vfs_read_0: (vfs_read+0x0/0x130) arg1=kernel_read+0x2c/0x40
tail-736 [000] ...2 105.754929: p_vfs_read_0: (vfs_read+0x0/0x130) arg1=kernel_read+0x2c/0x40
o $argN
# echo 'p vfs_read $arg0 $arg1 $arg2' > kprobe_events
# echo 1 > events/kprobes/p_vfs_read_0/enable
# tail -n 3 trace
sh-726 [007] ...2 134.288973: p_vfs_read_0: (vfs_read+0x0/0x130) arg1=0xffff88001d98ec00 arg2=0x7ffeb4330f79 arg3=0x1
tail-731 [000] ...2 134.289987: p_vfs_read_0: (vfs_read+0x0/0x130) arg1=0xffff88001d9dd200 arg2=0xffff88001d8a0a00 arg3=0x80
tail-731 [000] ...2 134.290016: p_vfs_read_0: (vfs_read+0x0/0x130) arg1=0xffff88001d9dd200 arg2=0xffff88001faf4a00 arg3=0x150
o Array type
# echo 'p vfs_read +0($stack):x64 +0($stack):x8[8]' > kprobe_events
# echo 1 > events/kprobes/p_vfs_read_0/enable
# tail -n 3 trace
sh-729 [007] ...2 91.701664: p_vfs_read_0: (vfs_read+0x0/0x130) arg1=0xffffffff811b1252 arg2={0x52,0x12,0x1b,0x81,0xff,0xff,0xff,0xff}
tail-734 [000] ...2 91.702366: p_vfs_read_0: (vfs_read+0x0/0x130) arg1=0xffffffff811b0dec arg2={0xec,0xd,0x1b,0x81,0xff,0xff,0xff,0xff}
tail-734 [000] ...2 91.702386: p_vfs_read_0: (vfs_read+0x0/0x130) arg1=0xffffffff811b0dec arg2={0xec,0xd,0x1b,0x81,0xff,0xff,0xff,0xff}
#
# cat events/kprobes/p_vfs_read_0/format
name: p_vfs_read_0
ID: 1069
format:
field:unsigned short common_type; offset:0; size:2; signed:0;
field:unsigned char common_flags; offset:2; size:1; signed:0;
field:unsigned char common_preempt_count; offset:3; size:1; signed:0;
field:int common_pid; offset:4; size:4; signed:1;
field:unsigned long __probe_ip; offset:8; size:8; signed:0;
field:u64 arg1; offset:16; size:0; signed:0;
field:u8 arg2[8]; offset:24; size:8; signed:0;
print fmt: "(%lx) arg1=0x%Lx arg2={0x%x,0x%x,0x%x,0x%x,0x%x,0x%x,0x%x,0x%x}", REC->__probe_ip, REC->arg1, REC->arg2[0], REC->arg2[1], REC->arg2[2], REC->arg2[3], REC->arg2[4], REC->arg2[5], REC->arg2[6], REC->arg2[7]
o String Array type
# echo "p create_trace_kprobe arg1=+0(%si):string[3]" > kprobe_events
# echo test1 test2 test3 >> kprobe_events
sh: write error: Invalid argument
# echo 'p vfs_read $stack' >> kprobe_events
# tail -n 2 trace
sh-744 [007] ...1 183.382407: p_create_trace_kprobe_0: (create_trace_kprobe+0x0/0x890) arg1={"test1","test2","test3"}
sh-744 [007] ...1 230.487809: p_create_trace_kprobe_0: (create_trace_kprobe+0x0/0x890) arg1={"p","vfs_read","$stack"}
Thank you,
---
Masami Hiramatsu (19):
[BUGFIX] tracing: probeevent: Fix to support minus offset from symbol
selftests: ftrace: Add probe event argument syntax testcase
selftests: ftrace: Add a testcase for string type with kprobe_event
selftests: ftrace: Add a testcase for probepoint
tracing: probeevent: Cleanup print argument functions
tracing: probeevent: Cleanup argument field definition
tracing: probeevent: Remove NOKPROBE_SYMBOL from print functions
tracing: probeevent: Introduce new argument fetching code
tracing: probeevent: Unify fetch type tables
tracing: probeevent: Return consumed bytes of dynamic area
tracing: probeevent: Append traceprobe_ for exported function
tracing: probeevent: Unify fetch_insn processing common part
tracing: probeevent: Add symbol type
x86: ptrace: Add function argument access API
tracing: probeevent: Add $argN for accessing function args
tracing: probeevent: Add array type support
selftests: ftrace: Add a testcase for symbol type
selftests: ftrace: Add a testcase for $argN with kprobe_event
selftests: ftrace: Add a testcase for array type with kprobe_event
Documentation/trace/kprobetrace.txt | 26 +
arch/Kconfig | 7
arch/x86/Kconfig | 1
arch/x86/include/asm/ptrace.h | 38 +
kernel/trace/trace.c | 9
kernel/trace/trace_kprobe.c | 366 ++++--------
kernel/trace/trace_probe.c | 628 +++++++++-----------
kernel/trace/trace_probe.h | 284 +++------
kernel/trace/trace_probe_tmpl.h | 214 +++++++
kernel/trace/trace_uprobe.c | 168 ++---
.../ftrace/test.d/kprobe/kprobe_args_argN.tc | 25 +
.../ftrace/test.d/kprobe/kprobe_args_array.tc | 92 +++
.../ftrace/test.d/kprobe/kprobe_args_string.tc | 46 +
.../ftrace/test.d/kprobe/kprobe_args_symbol.tc | 77 ++
.../ftrace/test.d/kprobe/kprobe_args_syntax.tc | 97 +++
.../selftests/ftrace/test.d/kprobe/probepoint.tc | 43 +
16 files changed, 1230 insertions(+), 891 deletions(-)
create mode 100644 kernel/trace/trace_probe_tmpl.h
create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_argN.tc
create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_array.tc
create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_symbol.tc
create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/probepoint.tc
--
Masami Hiramatsu (Linaro) <mhiramat@kernel.org>
next reply other threads:[~2018-02-28 3:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 3:19 Masami Hiramatsu [this message]
2018-02-28 3:19 ` [PATCH v4 01/19] [BUGFIX] tracing: probeevent: Fix to support minus offset from symbol Masami Hiramatsu
2018-03-02 4:49 ` Namhyung Kim
2018-03-02 6:32 ` Masami Hiramatsu
2018-03-05 2:28 ` Namhyung Kim
2018-03-05 10:05 ` Masami Hiramatsu
2018-02-28 3:20 ` [PATCH v4 02/19] selftests: ftrace: Add probe event argument syntax testcase Masami Hiramatsu
2018-02-28 3:20 ` [PATCH v4 03/19] selftests: ftrace: Add a testcase for string type with kprobe_event Masami Hiramatsu
2018-02-28 3:21 ` [PATCH v4 04/19] selftests: ftrace: Add a testcase for probepoint Masami Hiramatsu
2018-02-28 3:21 ` [PATCH v4 05/19] tracing: probeevent: Cleanup print argument functions Masami Hiramatsu
2018-02-28 3:22 ` [PATCH v4 06/19] tracing: probeevent: Cleanup argument field definition Masami Hiramatsu
2018-02-28 3:22 ` [PATCH v4 07/19] tracing: probeevent: Remove NOKPROBE_SYMBOL from print functions Masami Hiramatsu
2018-02-28 3:23 ` [PATCH v4 08/19] tracing: probeevent: Introduce new argument fetching code Masami Hiramatsu
2018-02-28 3:23 ` [PATCH v4 09/19] tracing: probeevent: Unify fetch type tables Masami Hiramatsu
2018-02-28 3:24 ` [PATCH v4 10/19] tracing: probeevent: Return consumed bytes of dynamic area Masami Hiramatsu
2018-02-28 3:24 ` [PATCH v4 11/19] tracing: probeevent: Append traceprobe_ for exported function Masami Hiramatsu
2018-02-28 3:25 ` [PATCH v4 12/19] tracing: probeevent: Unify fetch_insn processing common part Masami Hiramatsu
2018-02-28 3:25 ` [PATCH v4 13/19] tracing: probeevent: Add symbol type Masami Hiramatsu
2018-02-28 3:26 ` [PATCH v4 14/19] x86: ptrace: Add function argument access API Masami Hiramatsu
2018-02-28 3:26 ` [PATCH v4 15/19] tracing: probeevent: Add $argN for accessing function args Masami Hiramatsu
2018-02-28 3:27 ` [PATCH v4 16/19] tracing: probeevent: Add array type support Masami Hiramatsu
2018-02-28 3:27 ` [PATCH v4 17/19] selftests: ftrace: Add a testcase for symbol type Masami Hiramatsu
2018-02-28 3:28 ` [PATCH v4 18/19] selftests: ftrace: Add a testcase for $argN with kprobe_event Masami Hiramatsu
2018-03-02 5:31 ` Namhyung Kim
2018-03-02 6:20 ` Masami Hiramatsu
2018-02-28 3:28 ` [PATCH v4 19/19] selftests: ftrace: Add a testcase for array type " Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151978796240.2577.6531711990653677529.stgit@devbox \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox