From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752395AbeB1KM3 (ORCPT ); Wed, 28 Feb 2018 05:12:29 -0500 Received: from mga06.intel.com ([134.134.136.31]:38331 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752072AbeB1KM1 (ORCPT ); Wed, 28 Feb 2018 05:12:27 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,405,1515484800"; d="scan'208";a="34255365" Message-ID: <1519812742.10722.251.camel@linux.intel.com> Subject: Re: [PATCH v1 4/4] pci: Re-use new dmi_get_bios_year() helper From: Andy Shevchenko To: Bjorn Helgaas Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Jean Delvare , linux-kernel@vger.kernel.org Date: Wed, 28 Feb 2018 12:12:22 +0200 In-Reply-To: <20180226181943.GC25159@bhelgaas-glaptop.roam.corp.google.com> References: <20180222125923.57385-1-andriy.shevchenko@linux.intel.com> <20180222125923.57385-4-andriy.shevchenko@linux.intel.com> <20180223214051.GN14632@bhelgaas-glaptop.roam.corp.google.com> <1519565224.10722.148.camel@linux.intel.com> <20180226181943.GC25159@bhelgaas-glaptop.roam.corp.google.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.5-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2018-02-26 at 12:19 -0600, Bjorn Helgaas wrote: > On Sun, Feb 25, 2018 at 03:27:04PM +0200, Andy Shevchenko wrote: > > On Fri, 2018-02-23 at 15:40 -0600, Bjorn Helgaas wrote: > > > On Thu, Feb 22, 2018 at 02:59:23PM +0200, Andy Shevchenko wrote: > > > > ...instead of open coding its functionality. > > > > > > Same comment about making the changelog complete, independent of > > > the > > > subject. > > > > Any suggestion how it would look like? (Same question for previous > > comment) > > PCI: Re-use new dmi_get_bios_year() helper > > Use new dmi_get_bios_year() helper instead of open-coding its > functionality. > > The usual document structure is something like: > > TITLE > > This abstract contains a summary of the entire document, in a few > paragraphs of complete sentences. > > Where "TITLE" makes sense all by itself, even without reading the > body, and "Body" is a complete statement that also makes sense all by > itself without having to read "TITLE" first. > Thank you for a hint! > Granted, it's trivial, but following the convention improves > readability slightly because it fits the reader's expectations. > When the body is "...instead of open coding its functionality", it's a > bit of a hiccup because I have to start over and look back up to the > title to re-read the thing as a whole. OK, I got your point, though I don't like duplication in the subject and body. -- Andy Shevchenko Intel Finland Oy