From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935009AbeB1QRH (ORCPT ); Wed, 28 Feb 2018 11:17:07 -0500 Received: from mga06.intel.com ([134.134.136.31]:52336 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933165AbeB1QRE (ORCPT ); Wed, 28 Feb 2018 11:17:04 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,406,1515484800"; d="scan'208";a="21467345" Message-ID: <1519834622.10722.302.camel@linux.intel.com> Subject: Re: [PATCH v1] extcon: int3496: Ignore incorrect IoRestriction for ID pin From: Andy Shevchenko To: Hans de Goede , Chanwoo Choi , MyungJoo Ham , linux-kernel@vger.kernel.org Date: Wed, 28 Feb 2018 18:17:02 +0200 In-Reply-To: <3c1d4636-237c-2344-6c7c-fcd4468f48b9@redhat.com> References: <20180226193444.69883-1-andriy.shevchenko@linux.intel.com> <3c1d4636-237c-2344-6c7c-fcd4468f48b9@redhat.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.5-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2018-02-28 at 16:01 +0100, Hans de Goede wrote: > Hi, > > On 26-02-18 20:34, Andy Shevchenko wrote: > > The commit 70216fd937fe introduced a workaround for incorrect > > IoRestriction mode in ACPI table. > > > > Now, when GPIO ACPI library does it in generic way, just set > > an appropriate quirk flag instead. > > > > Cc: Hans de Goede > > Signed-off-by: Andy Shevchenko > > Looks good to me and everything still works after this change, > so with the earlier review remarks fixed this is: > > Reviewed-by: Hans de Goede > Tested-by: Hans de Goede Thanks! I will send a v2 soon. > > Regards, > > Hans > > > > > > > --- > > drivers/extcon/extcon-intel-int3496.c | 9 +++++---- > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/extcon/extcon-intel-int3496.c > > b/drivers/extcon/extcon-intel-int3496.c > > index 191e99f06a9a..acaccb128fc4 100644 > > --- a/drivers/extcon/extcon-intel-int3496.c > > +++ b/drivers/extcon/extcon-intel-int3496.c > > @@ -50,7 +50,11 @@ static const struct acpi_gpio_params vbus_gpios = > > { INT3496_GPIO_VBUS_EN, 0, fal > > static const struct acpi_gpio_params mux_gpios = { > > INT3496_GPIO_USB_MUX, 0, false }; > > > > static const struct acpi_gpio_mapping acpi_int3496_default_gpios[] > > = { > > - { "id-gpios", &id_gpios, 1 }, > > + /* > > + * Some platforms have a bug in ACPI GPIO description > > making IRQ > > + * GPIO to be output only. Ask the GPIO core to ignore this > > limit. > > + */ > > + { "id-gpios", &id_gpios, 1, > > ACPI_GPIO_QUIRK_NO_IO_RESTRICTION }, > > { "vbus-gpios", &vbus_gpios, 1 }, > > { "mux-gpios", &mux_gpios, 1 }, > > { }, > > @@ -112,9 +116,6 @@ static int int3496_probe(struct platform_device > > *pdev) > > ret = PTR_ERR(data->gpio_usb_id); > > dev_err(dev, "can't request USB ID GPIO: %d\n", > > ret); > > return ret; > > - } else if (gpiod_get_direction(data->gpio_usb_id) != > > GPIOF_DIR_IN) { > > - dev_warn(dev, FW_BUG "USB ID GPIO not in input > > mode, fixing\n"); > > - gpiod_direction_input(data->gpio_usb_id); > > } > > > > data->usb_id_irq = gpiod_to_irq(data->gpio_usb_id); > > -- Andy Shevchenko Intel Finland Oy