public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Yisheng Xie <xieyisheng1@huawei.com>,
	apw@canonical.com, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: avoid error report caused by syzbot
Date: Wed, 28 Feb 2018 08:37:31 -0800	[thread overview]
Message-ID: <1519835851.30349.7.camel@perches.com> (raw)
In-Reply-To: <1519809018-1736-1-git-send-email-xieyisheng1@huawei.com>

On Wed, 2018-02-28 at 17:10 +0800, Yisheng Xie wrote:
> syzbot request to add his reported-by when fix the bug find by syzbot.
> However, it will trigger a error when use checkpatch:
> 
>   ERROR: Unrecognized email address: 'syzbot+d7a918a7a8e1c952bc36@syzkaller.appspotmail.com'
> 
> For it include '+' in email and make regular expression works abnomal. Fix
> it by adding check for syzbot.
> 
> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>

Nack.

There's a proper patch already in -next

commit 14e45b3ecdb03211ab32656cd84e66fd6a28343e
Author: Joe Perches <joe@perches.com>
Date:   Thu Feb 22 09:59:45 2018 +1100

    checkpatch: improve parse_email signature checking
    
    Bare email addresses with non alphanumeric characters require escape
    quoting before being substituted in the parse_email routine.
    
    e.g. Reported-by: syzbot+bbd8e9a06452cc48059b@syzkaller.appspotmail.com
    
    Do so.
    
    Link: http://lkml.kernel.org/r/1518631805.3678.12.camel@perches.com

  reply	other threads:[~2018-02-28 16:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-28  9:10 [PATCH] checkpatch: avoid error report caused by syzbot Yisheng Xie
2018-02-28 16:37 ` Joe Perches [this message]
2018-03-01  0:44   ` Yisheng Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1519835851.30349.7.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xieyisheng1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox