From: David Laight <David.Laight@ACULAB.COM>
To: 'Jakub Kicinski' <kuba@kernel.org>, Yan Zhen <yanzhen@vivo.com>
Cc: "louis.peens@corigine.com" <louis.peens@corigine.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"oss-drivers@corigine.com" <oss-drivers@corigine.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"opensource.kernel@vivo.vom" <opensource.kernel@vivo.vom>
Subject: RE: [PATCH v1] netronome: nfp: Use min macro
Date: Sat, 31 Aug 2024 12:49:47 +0000 [thread overview]
Message-ID: <151a6133edc74d07a4488cdd83090d1a@AcuMS.aculab.com> (raw)
In-Reply-To: <20240827072423.4540bed6@kernel.org>
From: Jakub Kicinski
> Sent: 27 August 2024 15:24
>
> On Tue, 27 Aug 2024 16:40:05 +0800 Yan Zhen wrote:
> > Using min macro not only makes the code more concise and readable
> > but also improves efficiency sometimes.
>
> The code is fine, you're making it worse.
>
> How many of those pointless min()/max() conversions do you have
> for drivers/net ?
Maybe someone who understands cochineal should change the pattern
so that is require one of the 'arguments' to be non-trivial.
(or perhaps just delete the script ;-)
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
prev parent reply other threads:[~2024-08-31 12:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 8:40 [PATCH v1] netronome: nfp: Use min macro Yan Zhen
2024-08-27 14:24 ` Jakub Kicinski
2024-08-31 12:49 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151a6133edc74d07a4488cdd83090d1a@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=opensource.kernel@vivo.vom \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=yanzhen@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox