From: yannick fertre <yannick.fertre@st.com>
To: Vikas Manocha <vikas.manocha@st.com>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Yannick Fertre <yannick.fertre@st.com>,
Philippe Cornu <philippe.cornu@st.com>,
Patrice Chotard <patrice.chotard@st.com>,
Patrick DELAUNAY <patrick.delaunay@st.com>,
Christophe KERELLO <christophe.kerello@st.com>,
Archit Taneja <architt@codeaurora.org>,
Andrzej Hajda <a.hajda@samsung.com>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
David Airlie <airlied@linux.ie>,
Brian Norris <briannorris@chromium.org>,
Bhumika Goyal <bhumirks@gmail.com>,
Gustavo Padovan <gustavo@padovan.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
Sean Paul <seanpaul@chromium.org>,
Albert Aribaud <albert.u.boot@aribaud.net>,
"Simon Glass" <sjg@chromium.org>,
Anatolij Gustschin <agust@denx.de>,
Thierry Reding <thierry.reding@gmail.com>
Cc: <u-boot@lists.denx.de>, <dri-devel@lists.freedesktop.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v2 02/10] video: stm32: stm32_ltdc: update debug log
Date: Fri, 2 Mar 2018 16:44:03 +0100 [thread overview]
Message-ID: <1520005451-23217-3-git-send-email-yannick.fertre@st.com> (raw)
In-Reply-To: <1520005451-23217-1-git-send-email-yannick.fertre@st.com>
Replace macro debug by pr_error, pr_warn or pr_info.
Signed-off-by: yannick fertre <yannick.fertre@st.com>
---
drivers/video/stm32/stm32_ltdc.c | 62 ++++++++++++++++++++--------------------
1 file changed, 31 insertions(+), 31 deletions(-)
diff --git a/drivers/video/stm32/stm32_ltdc.c b/drivers/video/stm32/stm32_ltdc.c
index bd9c0de..e95f35c 100644
--- a/drivers/video/stm32/stm32_ltdc.c
+++ b/drivers/video/stm32/stm32_ltdc.c
@@ -176,13 +176,13 @@ static u32 stm32_ltdc_get_pixel_format(enum video_log2_bpp l2bpp)
case VIDEO_BPP2:
case VIDEO_BPP4:
default:
- debug("%s: warning %dbpp not supported yet, %dbpp instead\n",
- __func__, VNBITS(l2bpp), VNBITS(VIDEO_BPP16));
+ pr_warn("%s: warning %dbpp not supported yet, %dbpp instead\n",
+ __func__, VNBITS(l2bpp), VNBITS(VIDEO_BPP16));
pf = PF_RGB565;
break;
}
- debug("%s: %d bpp -> ltdc pf %d\n", __func__, VNBITS(l2bpp), pf);
+ pr_info("%s: %d bpp -> ltdc pf %d\n", __func__, VNBITS(l2bpp), pf);
return (u32)pf;
}
@@ -249,7 +249,7 @@ static void stm32_ltdc_set_mode(struct stm32_ltdc_priv *priv,
/* Signal polarities */
val = 0;
- debug("%s: timing->flags 0x%08x\n", __func__, timings->flags);
+ pr_info("%s: timing->flags 0x%08x\n", __func__, timings->flags);
if (timings->flags & DISPLAY_FLAGS_HSYNC_HIGH)
val |= GCR_HSPOL;
if (timings->flags & DISPLAY_FLAGS_VSYNC_HIGH)
@@ -343,26 +343,26 @@ static int stm32_ltdc_probe(struct udevice *dev)
priv->regs = (void *)dev_read_addr(dev);
if ((fdt_addr_t)priv->regs == FDT_ADDR_T_NONE) {
- debug("%s: ltdc dt register address error\n", __func__);
+ pr_err("%s: ltdc dt register address error\n", __func__);
return -EINVAL;
}
ret = clk_get_by_index(dev, 0, &pclk);
if (ret) {
- debug("%s: peripheral clock get error %d\n", __func__, ret);
+ pr_err("%s: peripheral clock get error %d\n", __func__, ret);
return ret;
}
ret = clk_enable(&pclk);
if (ret) {
- debug("%s: peripheral clock enable error %d\n",
- __func__, ret);
+ pr_err("%s: peripheral clock enable error %d\n",
+ __func__, ret);
return ret;
}
ret = reset_get_by_index(dev, 0, &rst);
if (ret) {
- debug("%s: missing ltdc hardware reset\n", __func__);
+ pr_err("%s: missing ltdc hardware reset\n", __func__);
return -ENODEV;
}
@@ -372,41 +372,40 @@ static int stm32_ltdc_probe(struct udevice *dev)
#ifdef CONFIG_VIDEO_BRIDGE
ret = uclass_get_device(UCLASS_VIDEO_BRIDGE, 0, &bridge);
if (ret) {
- debug("%s: No video bridge, or no backlight on bridge\n",
- __func__);
+ pr_info("%s: No video bridge, or no backlight on bridge\n",
+ __func__);
}
if (bridge) {
ret = video_bridge_attach(bridge);
if (ret) {
- debug("%s: fail to attach bridge\n", __func__);
+ pr_err("%s: fail to attach bridge\n", __func__);
return ret;
}
}
#endif
ret = uclass_first_device(UCLASS_PANEL, &panel);
if (ret) {
- debug("%s: panel device error %d\n", __func__, ret);
+ pr_err("%s: panel device error %d\n", __func__, ret);
return ret;
}
ret = fdtdec_decode_display_timing(gd->fdt_blob, dev_of_offset(panel),
0, &timings);
if (ret) {
- debug("%s: decode display timing error %d\n",
- __func__, ret);
+ pr_err("%s: decode display timing error %d\n", __func__, ret);
return ret;
}
rate = clk_set_rate(&pclk, timings.pixelclock.typ);
if (rate < 0) {
- debug("%s: fail to set pixel clock %d hz %d hz\n",
- __func__, timings.pixelclock.typ, rate);
+ pr_err("%s: fail to set pixel clock %d hz %d hz\n",
+ __func__, timings.pixelclock.typ, rate);
return rate;
}
- debug("%s: Set pixel clock req %d hz get %d hz\n", __func__,
- timings.pixelclock.typ, rate);
+ pr_info("%s: Set pixel clock req %d hz get %d hz\n", __func__,
+ timings.pixelclock.typ, rate);
/* TODO Below parameters are hard-coded for the moment... */
priv->l2bpp = VIDEO_BPP16;
@@ -417,12 +416,12 @@ static int stm32_ltdc_probe(struct udevice *dev)
priv->crop_h = timings.vactive.typ;
priv->alpha = 0xFF;
- debug("%s: %dx%d %dbpp frame buffer at 0x%lx\n", __func__,
- timings.hactive.typ, timings.vactive.typ,
- VNBITS(priv->l2bpp), uc_plat->base);
- debug("%s: crop %d,%d %dx%d bg 0x%08x alpha %d\n", __func__,
- priv->crop_x, priv->crop_y, priv->crop_w, priv->crop_h,
- priv->bg_col_argb, priv->alpha);
+ pr_info("%s: %dx%d %dbpp frame buffer at 0x%lx\n", __func__,
+ timings.hactive.typ, timings.vactive.typ,
+ VNBITS(priv->l2bpp), uc_plat->base);
+ pr_info("%s: crop %d,%d %dx%d bg 0x%08x alpha %d\n", __func__,
+ priv->crop_x, priv->crop_y, priv->crop_w, priv->crop_h,
+ priv->bg_col_argb, priv->alpha);
/* Configure & start LTDC */
stm32_ltdc_set_mode(priv, &timings);
@@ -437,22 +436,22 @@ static int stm32_ltdc_probe(struct udevice *dev)
if (bridge) {
ret = video_bridge_set_backlight(bridge, 80);
if (ret) {
- debug("%s: fail to set backlight\n", __func__);
+ pr_err("%s: fail to set backlight\n", __func__);
return ret;
}
} else {
ret = panel_enable_backlight(panel);
if (ret) {
- debug("%s: panel %s enable backlight error %d\n",
- __func__, panel->name, ret);
+ pr_err("%s: panel %s enable backlight error %d\n",
+ __func__, panel->name, ret);
return ret;
}
}
#else
ret = panel_enable_backlight(panel);
if (ret) {
- debug("%s: panel %s enable backlight error %d\n",
- __func__, panel->name, ret);
+ pr_err("%s: panel %s enable backlight error %d\n",
+ __func__, panel->name, ret);
return ret;
}
#endif
@@ -468,7 +467,8 @@ static int stm32_ltdc_bind(struct udevice *dev)
uc_plat->size = CONFIG_VIDEO_STM32_MAX_XRES *
CONFIG_VIDEO_STM32_MAX_YRES *
(CONFIG_VIDEO_STM32_MAX_BPP >> 3);
- debug("%s: frame buffer max size %d bytes\n", __func__, uc_plat->size);
+ pr_info("%s: frame buffer max size %d bytes\n", __func__,
+ uc_plat->size);
return 0;
}
--
1.9.1
next prev parent reply other threads:[~2018-03-02 15:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 15:44 [PATCH v2 00/10] splash screen on the stm32f769 disco board yannick fertre
2018-03-02 15:44 ` [PATCH v2 01/10] video: stm32: stm32_ltdc: add bridge to display controller yannick fertre
2018-03-13 8:44 ` Patrice CHOTARD
2018-03-02 15:44 ` yannick fertre [this message]
2018-03-13 8:48 ` [PATCH v2 02/10] video: stm32: stm32_ltdc: update debug log Patrice CHOTARD
2018-03-02 15:44 ` [PATCH v2 03/10] video: add support of MIPI DSI interface yannick fertre
2018-03-02 15:44 ` [PATCH v2 04/10] video: add support of panel OTM8009A yannick fertre
2018-03-13 8:52 ` Patrice CHOTARD
2018-03-02 15:44 ` [PATCH v2 05/10] video: add MIPI DSI host controller bridge yannick fertre
2018-03-02 18:58 ` Brian Norris
2018-03-02 19:02 ` Brian Norris
2018-03-02 15:44 ` [PATCH v2 06/10] video: add support of STM32 MIPI DSI controller driver yannick fertre
2018-03-13 8:56 ` Patrice CHOTARD
2018-03-02 15:44 ` [PATCH v2 07/10] video: add support of panel rm68200 yannick fertre
2018-03-13 8:59 ` Patrice CHOTARD
2018-03-02 15:44 ` [PATCH v2 08/10] arm: dts: stm32: add dsi for STM32F746 yannick fertre
2018-03-02 15:44 ` [PATCH v2 09/10] arm: dts: stm32: add display for STM32F769 disco board yannick fertre
2018-03-02 15:44 ` [PATCH v2 10/10] board: Add STM32F769 SoC, discovery board support yannick fertre
2018-03-13 8:41 ` Patrice CHOTARD
2018-03-06 17:51 ` [PATCH v2 00/10] splash screen on the stm32f769 disco board Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520005451-23217-3-git-send-email-yannick.fertre@st.com \
--to=yannick.fertre@st.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=agust@denx.de \
--cc=airlied@linux.ie \
--cc=albert.u.boot@aribaud.net \
--cc=architt@codeaurora.org \
--cc=benjamin.gaignard@linaro.org \
--cc=bhumirks@gmail.com \
--cc=briannorris@chromium.org \
--cc=christophe.kerello@st.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=patrice.chotard@st.com \
--cc=patrick.delaunay@st.com \
--cc=philippe.cornu@st.com \
--cc=seanpaul@chromium.org \
--cc=sjg@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=u-boot@lists.denx.de \
--cc=vikas.manocha@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).