linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, linux-kernel@vger.kernel.org
Subject: [PATCH 9/9] perf intel-pt: Adjust overlap-checking to support sampling mode
Date: Wed,  7 Mar 2018 16:02:29 +0200	[thread overview]
Message-ID: <1520431349-30689-10-git-send-email-adrian.hunter@intel.com> (raw)
In-Reply-To: <1520431349-30689-1-git-send-email-adrian.hunter@intel.com>

Adjust overlap-checking to support sampling mode.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
 tools/perf/util/intel-pt.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/tools/perf/util/intel-pt.c b/tools/perf/util/intel-pt.c
index 5c5c155fba78..0effaff57020 100644
--- a/tools/perf/util/intel-pt.c
+++ b/tools/perf/util/intel-pt.c
@@ -230,6 +230,7 @@ static int intel_pt_get_trace(struct intel_pt_buffer *b, void *data)
 	struct auxtrace_buffer *buffer = ptq->buffer;
 	struct auxtrace_buffer *old_buffer = ptq->old_buffer;
 	struct auxtrace_queue *queue;
+	bool might_overlap;
 
 	if (ptq->stop) {
 		b->len = 0;
@@ -256,7 +257,8 @@ static int intel_pt_get_trace(struct intel_pt_buffer *b, void *data)
 			return -ENOMEM;
 	}
 
-	if (ptq->pt->snapshot_mode && !buffer->consecutive && old_buffer &&
+	might_overlap = ptq->pt->snapshot_mode || ptq->pt->sampling_mode;
+	if (might_overlap && !buffer->consecutive && old_buffer &&
 	    intel_pt_do_fix_overlap(ptq->pt, old_buffer, buffer))
 		return -ENOMEM;
 
@@ -269,8 +271,7 @@ static int intel_pt_get_trace(struct intel_pt_buffer *b, void *data)
 	}
 	b->ref_timestamp = buffer->reference;
 
-	if (!old_buffer || ptq->pt->sampling_mode || (ptq->pt->snapshot_mode &&
-						      !buffer->consecutive)) {
+	if (!old_buffer || (might_overlap && !buffer->consecutive)) {
 		b->consecutive = false;
 		b->trace_nr = buffer->buffer_nr + 1;
 	} else {
-- 
1.9.1

  parent reply	other threads:[~2018-03-07 14:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-07 14:02 [PATCH 0/9] perf intel-pt: Some fixes and preparation for AUX area sampling Adrian Hunter
2018-03-07 14:02 ` [PATCH 1/9] perf intel-pt: Fix overlap detection to identify consecutive buffers correctly Adrian Hunter
2018-03-09  8:47   ` [tip:perf/core] " tip-bot for Adrian Hunter
2018-03-07 14:02 ` [PATCH 2/9] perf intel-pt: Fix sync_switch Adrian Hunter
2018-03-09  8:47   ` [tip:perf/core] " tip-bot for Adrian Hunter
2018-03-07 14:02 ` [PATCH 3/9] perf intel-pt: Fix error recovery from missing TIP packet Adrian Hunter
2018-03-09  8:48   ` [tip:perf/core] " tip-bot for Adrian Hunter
2018-03-07 14:02 ` [PATCH 4/9] perf intel-pt: Fix timestamp following overflow Adrian Hunter
2018-03-09  8:48   ` [tip:perf/core] " tip-bot for Adrian Hunter
2018-03-07 14:02 ` [PATCH 5/9] perf intel-pt/bts: In auxtrace_record__init_intel() evlist is never NULL Adrian Hunter
2018-03-09  8:49   ` [tip:perf/core] " tip-bot for Adrian Hunter
2018-03-07 14:02 ` [PATCH 6/9] perf intel-pt: Get rid of intel_pt_use_buffer_pid_tid() Adrian Hunter
2018-03-09  8:49   ` [tip:perf/core] " tip-bot for Adrian Hunter
2018-03-07 14:02 ` [PATCH 7/9] perf intel-pt: Tidy old_buffer handling in intel_pt_get_trace() Adrian Hunter
2018-03-09  8:50   ` [tip:perf/core] " tip-bot for Adrian Hunter
2018-03-07 14:02 ` [PATCH 8/9] perf intel-pt: Remove a check for sampling mode Adrian Hunter
2018-03-09  8:50   ` [tip:perf/core] " tip-bot for Adrian Hunter
2018-03-07 14:02 ` Adrian Hunter [this message]
2018-03-09  8:51   ` [tip:perf/core] perf intel-pt: Adjust overlap-checking to support " tip-bot for Adrian Hunter
2018-03-07 14:36 ` [PATCH 0/9] perf intel-pt: Some fixes and preparation for AUX area sampling Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1520431349-30689-10-git-send-email-adrian.hunter@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).