From: Daniel Schultz <d.schultz@phytec.de>
To: lee.jones@linaro.org
Cc: zyw@rock-chips.com, zhangqing@rock-chips.com,
chenjh@rock-chips.com, linux-kernel@vger.kernel.org,
w.egorov@phytec.de
Subject: [PATCH v2 1/2] mfd: rk808: Change DEV_OFF to DEV_OFF_RST for rk818 shutdown
Date: Wed, 7 Mar 2018 18:01:49 +0100 [thread overview]
Message-ID: <1520442110-28420-1-git-send-email-d.schultz@phytec.de> (raw)
After running "poweroff", the PMIC restarts the SoC instead of shutting
it down.
It seems like the description for those two register bits is swapped.
After changing from DEV_OFF to DEV_OFF_RST, the system can poweroff
correctly.
Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
---
Changes:
v2: Re-submit with recipients from Rockchip.
drivers/mfd/rk808.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
index 216fbf6..d138721 100644
--- a/drivers/mfd/rk808.c
+++ b/drivers/mfd/rk808.c
@@ -418,7 +418,7 @@ static void rk818_device_shutdown(void)
ret = regmap_update_bits(rk808->regmap,
RK818_DEVCTRL_REG,
- DEV_OFF, DEV_OFF);
+ DEV_OFF_RST, DEV_OFF_RST);
if (ret)
dev_err(&rk808_i2c_client->dev, "power off error!\n");
}
--
2.7.4
next reply other threads:[~2018-03-07 17:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 17:01 Daniel Schultz [this message]
2018-03-07 17:01 ` [PATCH v2 2/2] mfd: rk808: Add restart functionality Daniel Schultz
2018-03-12 14:10 ` Lee Jones
2018-03-13 3:32 ` Joseph Chen
2018-03-13 9:48 ` Daniel Schultz
2018-03-14 3:08 ` Joseph Chen
2018-03-12 14:09 ` [PATCH v2 1/2] mfd: rk808: Change DEV_OFF to DEV_OFF_RST for rk818 shutdown Lee Jones
[not found] ` <040f2e2d-680d-8da3-75df-78da16cc46ba@rock-chips.com>
2018-03-13 14:14 ` Daniel Schultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520442110-28420-1-git-send-email-d.schultz@phytec.de \
--to=d.schultz@phytec.de \
--cc=chenjh@rock-chips.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=w.egorov@phytec.de \
--cc=zhangqing@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).