[PATCH] clk: fix phase reported being zero

[PATCH] clk: fix phase reported being zero

[Jerome Brunet]

While introducing clk_core_set_phase_nolock, assigning core->phase was
mistakenly removed. Fixing this now

Fixes: 9e4d04adeb1a ("clk: add clk_core_set_phase_nolock function")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 drivers/clk/clk.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 9d56be6ead39..b33d362239e7 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -2314,6 +2314,9 @@ static int clk_core_set_phase_nolock(struct clk_core *core, int degrees)
 	if (core->ops->set_phase)
 		ret = core->ops->set_phase(core->hw, degrees);
 
+	if (!ret)
+		core->phase = degrees;
+
 	trace_clk_set_phase_complete(core, degrees);
 
 	return ret;
-- 
2.14.3

Re: [PATCH] clk: fix phase reported being zero

[Jerome Brunet]

On Thu, 2018-02-15 at 11:19 +0100, Jerome Brunet wrote:
> While introducing clk_core_set_phase_nolock, assigning core->phase was
> mistakenly removed. Fixing this now
> 
> Fixes: 9e4d04adeb1a ("clk: add clk_core_set_phase_nolock function")
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

Please drop this patch if favor of 

https://lkml.kernel.org/r/1520491781-132529-1-git-send-email-shawn.lin@rock-chip
s.com

Thanks
Jerome

> ---
>  drivers/clk/clk.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 9d56be6ead39..b33d362239e7 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -2314,6 +2314,9 @@ static int clk_core_set_phase_nolock(struct clk_core *core, int degrees)
>  	if (core->ops->set_phase)
>  		ret = core->ops->set_phase(core->hw, degrees);
>  
> +	if (!ret)
> +		core->phase = degrees;
> +
>  	trace_clk_set_phase_complete(core, degrees);
>  
>  	return ret;