public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jason Gunthorpe <jgg@mellanox.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Andy Whitcroft <apw@canonical.com>
Cc: Doug Ledford <dledford@redhat.com>,
	Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Leon Romanovsky <leonro@mellanox.com>
Subject: Re: linux-next: Signed-off-by missing for commit in the rdma-fixes tree
Date: Thu, 08 Mar 2018 08:39:38 -0800	[thread overview]
Message-ID: <1520527178.11634.9.camel@perches.com> (raw)
In-Reply-To: <20180308161845.GC6773@mellanox.com>

On Thu, 2018-03-08 at 09:18 -0700, Jason Gunthorpe wrote:
> On Thu, Mar 08, 2018 at 04:40:58PM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Commit
> > 
> >   aa0de36a40f4 ("RDMA/mlx5: Fix integer overflow while resizing CQ")
> > 
> > is missing a Signed-off-by from its author.
> 
> Thanks Stephen,
> 
> May I suggest to the checkpatch maintainers that checkpack should look
> for this too?

No such commit in current -hext
$ git status HEAD
HEAD detached at next-20180308

checkpatch doesn't try to match email sender to sign-off
as the email sender doesn't have to sign-off on a patch.

It currently does:

	if ($is_patch && $has_commit_log && $chk_signoff && $signoff == 0) {
		ERROR("MISSING_SIGN_OFF",
		      "Missing Signed-off-by: line(s)\n");
	}

  reply	other threads:[~2018-03-08 16:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-08  5:40 linux-next: Signed-off-by missing for commit in the rdma-fixes tree Stephen Rothwell
2018-03-08  6:09 ` Leon Romanovsky
2018-03-08 13:28   ` Doug Ledford
2018-03-08 13:38     ` Leon Romanovsky
2018-03-08 15:10     ` Jason Gunthorpe
2018-03-08 16:18 ` Jason Gunthorpe
2018-03-08 16:39   ` Joe Perches [this message]
2018-03-08 17:03     ` Jason Gunthorpe
2018-03-08 17:23       ` Joe Perches
2018-03-08 17:44         ` Jason Gunthorpe
2018-03-08 17:52           ` Joe Perches
  -- strict thread matches above, loose matches on Subject: below --
2022-10-27 19:23 Stephen Rothwell
2022-10-28 15:54 ` Jason Gunthorpe
2023-01-17 21:04 Stephen Rothwell
2023-01-18 15:17 ` Jason Gunthorpe
2024-10-07 20:51 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1520527178.11634.9.camel@perches.com \
    --to=joe@perches.com \
    --cc=apw@canonical.com \
    --cc=dledford@redhat.com \
    --cc=jgg@mellanox.com \
    --cc=leonro@mellanox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox