From: Andreas Christoforou <andreaschristofo@gmail.com>
To: keescook@chromium.org
Cc: kernel-hardening@lists.openwall.com,
Andreas Christoforou <andreaschristofo@gmail.com>,
Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] net: ipv6: xfrm6_state: remove VLA usage
Date: Fri, 9 Mar 2018 14:21:46 +0200 [thread overview]
Message-ID: <1520598106-3271-1-git-send-email-andreaschristofo@gmail.com> (raw)
The kernel would like to have all stack VLA usage removed[1].
Signed-off-by: Andreas Christoforou <andreaschristofo@gmail.com>
---
net/ipv6/xfrm6_state.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/net/ipv6/xfrm6_state.c b/net/ipv6/xfrm6_state.c
index b15075a..45c0d98 100644
--- a/net/ipv6/xfrm6_state.c
+++ b/net/ipv6/xfrm6_state.c
@@ -62,7 +62,12 @@ __xfrm6_sort(void **dst, void **src, int n, int (*cmp)(void *p), int maxclass)
{
int i;
int class[XFRM_MAX_DEPTH];
- int count[maxclass];
+ int *count;
+
+ count = kcalloc(maxclass + 1, sizeof(*count), GFP_KERNEL);
+
+ if (!count)
+ return -ENOMEM;
memset(count, 0, sizeof(count));
@@ -80,6 +85,7 @@ __xfrm6_sort(void **dst, void **src, int n, int (*cmp)(void *p), int maxclass)
src[i] = NULL;
}
+ kfree(count);
return 0;
}
--
2.7.4
next reply other threads:[~2018-03-09 12:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 12:21 Andreas Christoforou [this message]
2018-03-09 12:35 ` [PATCH] net: ipv6: xfrm6_state: remove VLA usage Steffen Klassert
2018-03-09 12:49 ` Mathias Krause
2018-03-09 13:02 ` Steffen Klassert
2018-03-09 13:49 ` Andreas Christoforou
2018-03-09 18:35 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520598106-3271-1-git-send-email-andreaschristofo@gmail.com \
--to=andreaschristofo@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox