From: Joe Perches <joe@perches.com>
To: "Herbert Xu" <herbert@gondor.apana.org.au>,
"Hernán Gonzalez" <hernan@vanguardiasur.com.ar>
Cc: davem@davemloft.net, steven.lin1@broadcom.com,
arvind.yadav.cs@gmail.com, colin.king@canonical.com,
raveendra.padasalagi@broadcom.com, ray.jui@broadcom.com,
scott.branden@broadcom.com, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] crypto: bcm: Constify *hash_alg_name[]
Date: Fri, 09 Mar 2018 06:35:35 -0800 [thread overview]
Message-ID: <1520606135.26370.9.camel@perches.com> (raw)
In-Reply-To: <20180309142954.GA12852@gondor.apana.org.au>
On Fri, 2018-03-09 at 22:29 +0800, Herbert Xu wrote:
> On Tue, Feb 27, 2018 at 07:01:27PM -0300, Hernán Gonzalez wrote:
> > Note: This is compile only tested.
> > No gain from this except some self-documenting.
[]
> > diff --git a/drivers/crypto/bcm/spu.c b/drivers/crypto/bcm/spu.c
[]
> > @@ -23,8 +23,9 @@
> > #include "cipher.h"
> >
> > /* This array is based on the hash algo type supported in spu.h */
> > -char *hash_alg_name[] = { "None", "md5", "sha1", "sha224", "sha256", "aes",
> > - "sha384", "sha512", "sha3_224", "sha3_256", "sha3_384", "sha3_512" };
> > +char const * const hash_alg_name[] = { "None", "md5", "sha1", "sha224",
>
> Please make that
>
> const char *const
>
> Ditto with patch 4.
>
> Thanks,
and likely, as this is a global name, it should
be something like crypto_hash_alg_name
next prev parent reply other threads:[~2018-03-09 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 22:01 [PATCH 1/4] crypto: bcm: Remove unused variable (char *tag_to_hash_idx[]) Hernán Gonzalez
2018-02-27 22:01 ` [PATCH 2/4] crypto: bcm: Move *aead_alg_name[] from spu.c to util.c. Constify too Hernán Gonzalez
2018-02-27 22:01 ` [PATCH 3/4] crypto: bcm: Constify *hash_alg_name[] Hernán Gonzalez
2018-03-09 14:29 ` Herbert Xu
2018-03-09 14:35 ` Joe Perches [this message]
2018-03-09 15:04 ` Herbert Xu
2018-03-09 15:04 ` Kamil Konieczny
2018-02-27 22:01 ` [PATCH 4/4] crypto: bcm: Constify variables in spu2.c Hernán Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520606135.26370.9.camel@perches.com \
--to=joe@perches.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=hernan@vanguardiasur.com.ar \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raveendra.padasalagi@broadcom.com \
--cc=ray.jui@broadcom.com \
--cc=scott.branden@broadcom.com \
--cc=steven.lin1@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox