From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: "kbuild test robot" <fengguang.wu@intel.com>,
"Hernán Gonzalez" <hernan@vanguardiasur.com.ar>
Cc: kbuild-all@01.org, James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH linux-next] evm: evm_hmac can be static
Date: Tue, 13 Mar 2018 14:16:42 -0400 [thread overview]
Message-ID: <1520965002.3547.342.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180313174224.GA28779@intel17>
On Wed, 2018-03-14 at 01:42 +0800, kbuild test robot wrote:
> Fixes: c49fc264be98 ("evm: Move evm_hmac and evm_hash from evm_main.c to evm_crypto.c")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Thanks!
> ---
> evm_crypto.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/security/integrity/evm/evm_crypto.c b/security/integrity/evm/evm_crypto.c
> index fdde9cb..a46fba3 100644
> --- a/security/integrity/evm/evm_crypto.c
> +++ b/security/integrity/evm/evm_crypto.c
> @@ -37,8 +37,8 @@ static DEFINE_MUTEX(mutex);
>
> static unsigned long evm_set_key_flags;
>
> -char * const evm_hmac = "hmac(sha1)";
> -char * const evm_hash = "sha1";
> +static char * const evm_hmac = "hmac(sha1)";
> +static char * const evm_hash = "sha1";
>
> /**
> * evm_set_key() - set EVM HMAC key from the kernel
prev parent reply other threads:[~2018-03-13 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 17:42 [linux-next:master 6699/7643] security/integrity/evm/evm_crypto.c:40:6: sparse: symbol 'evm_hmac' was not declared. Should it be static? kbuild test robot
2018-03-13 17:42 ` [RFC PATCH linux-next] evm: evm_hmac can be static kbuild test robot
2018-03-13 18:16 ` Mimi Zohar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520965002.3547.342.camel@linux.vnet.ibm.com \
--to=zohar@linux.vnet.ibm.com \
--cc=fengguang.wu@intel.com \
--cc=hernan@vanguardiasur.com.ar \
--cc=jmorris@namei.org \
--cc=kbuild-all@01.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox