Re: [reiserfs-dev] Re: [PATCH]: reiserfs: D-clear-i_blocks.patch

[Nikita Danilov <NikitaDanilov@Yahoo.COM>]

jlnance@intrex.net writes:
 > On Thu, Aug 02, 2001 at 10:31:15PM +0400, Nikita Danilov wrote:
 > > Andreas Dilger writes:
 > >  > PS - could someone on the reiserfs team (or Linus) run the reiserfs code
 > >  >      through "indent" (or auto format in emacs) per
 > >  >      Documentation/CodingStyle?  It is really a gross mess, to such a
 > >  >      point that you can hardly see what
 > > 
 > > Oh, yes.
 > > 
 > >  >      is going on.  It's not just that it is a different indent style, it
 > >  >      has no coherent indentation or comment formatting at all.  Maybe
 > >  >      for 2.5?
 > > 
 > > I hope so. We already have 200k of cleanup patches in 2.4.7-ac3.
 > 
 > >From past experience, if you want to run the code through indent, I would
 > recomend that you submit patches for that which contain no other changes.
 > If you mix indent changes with code changes, it gets very difficult to
 > see what was actually changed if bugs crop up.

Thank you. Do you have an experience in or opinion on asking Linus to
perform such conversion himself, because this will probably save some
trouble?

 > 
 > Thanks,
 > 
 > Jim

[lkml: please CC me, I am not subscribed.]

Nikita.