From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AG47ELs7cd2DaQdHEUR5HreO6aRq33jWFwPBAVByxtA78wej5q5l+Qce8a1Bo3+uqEFwaWq54ZOX ARC-Seal: i=1; a=rsa-sha256; t=1521106354; cv=none; d=google.com; s=arc-20160816; b=FViMa9souyPE2ujz9wWxfRY/TReq1qRP0rlXbceS4jaQarbojd391ure7+fy1WeZG4 5953BIGRvNw1KX1LsXj3K6sBBa9k4ocQxFEWzEzBj76BN7YJ/Dp0dRdMRHoNfJl+8kUP qXkl7m86gVfwPnNC2sIvVEE52o2FfKnN0eLWds0BGf92iErQBb8yM25T9WdvImJSV/IM RyK8cJJkYucjd64NUibXjffDTHryo/X9MWV/fRn9hgjy9SpZe5+J/cLYRZ6gUIjCQj8s 2gl9WS2wV5FoxD9Dd4JM+KojACICX0BGHJ/9FSWP6QjIu7IUGxzNy/aPGwbg1mku2Atd rbFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to:date :cc:to:from:subject:message-id:arc-authentication-results; bh=rwZFKBVfbXCKXG4+PihRiojiomad4J+LorIqPOqiAeg=; b=ywCKoKMGkpw8EjJkIHhI2VavsQkmLCmZs93G0SSnAG84JuuXw87Pjdx574KFBIUvcz 9p0Cv1kvZkBWXTRcnpoEjLjoiRVc/9TGstlMZvuup1uw6mNjaRRgRZLq3+3E6fzWFcda l0W2kBW1wNXz5WmBELFrBOILOPk22L6Y0BtvpPzQirIQ43i8duH7zM8iRTCdmENtJZp6 wxCd/rQ6NXDZlIxzAKXyV8LazKQ2w7vSux8KBFLCojsRam8jxb6lOiQ/AIHdpqTvm/Q1 JM981LFFIvpkaqoePGaMtu6t4mv7BNH61uiHDNjPC+pVhHebwhcGTQRkjDRp/ktb/KtR 84mA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of oneukum@suse.com designates 195.135.220.15 as permitted sender) smtp.mailfrom=oneukum@suse.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of oneukum@suse.com designates 195.135.220.15 as permitted sender) smtp.mailfrom=oneukum@suse.com Message-ID: <1521105992.18237.2.camel@suse.com> Subject: Re: [PATCH 2/3] usb: host: pci: introduce PCI vendor ID for Netlogic From: Oliver Neukum To: Richard Leitner , Richard Leitner , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-usb@vger.kernel.org Cc: bhelgaas@google.com, mathias.nyman@intel.com, gregkh@linuxfoundation.org Date: Thu, 15 Mar 2018 10:26:32 +0100 In-Reply-To: <377fb9d5-1cc9-7ab8-c965-2fb0a4dc20f3@skidata.com> References: <20180314102933.21367-1-dev@g0hl1n.net> <20180314102933.21367-3-dev@g0hl1n.net> <1521029854.4511.12.camel@suse.com> <1521041253.4511.16.camel@suse.com> <377fb9d5-1cc9-7ab8-c965-2fb0a4dc20f3@skidata.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1594908624828665894?= X-GMAIL-MSGID: =?utf-8?q?1594995616527512718?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Am Mittwoch, den 14.03.2018, 16:44 +0100 schrieb Richard Leitner: > On 03/14/2018 04:27 PM, Oliver Neukum wrote: > > Am Mittwoch, den 14.03.2018, 14:31 +0100 schrieb Richard Leitner: > > > > > Well, but it does not. Removing a redundant definition is a clear > > benefit. But you are not removing a definition. You are introducing > > a preprocessor constant. Why? > > What is its benefit? > > AFAIK pci_ids.h collects PCI vendor and device IDs in one single > point. As the PCI vendor ID of Netlogic is used in multiple files > IMHO it would be a good idea to add it to pci_ids.h and furthermore > remove it from arch/mips/include/asm/netlogic/xlp-hal/iomap.h (where > it's currently defined). > > Or am I getting things wrong? I think so, yes. We are giving names to constants as a form of comment or to change them at multiple places at once and consistently. So #define XYZ_NETDEV_RESET_RETRIES 2 makes clearly sense. So does #define XYZ_MAGIC_VALUE1 0xab4e because it tells you that you have a magic value. But you will never redefine a PCI vendor ID. In fact you must not. And if you have a comparison like dev->vID == 0x1234 if you change this to dev->vID == SOME_VENDOR_ID what good does this to you? You already knew it was a vendor ID. Now you can name it at a glance. So what? If you have a device you will have to check whether you have some OEM version. You will always go and check the raw number. And if you have a log and need to check whether the check will be true, you will have a number. Using a constant there is nothing but trouble. Yet one more grep. Regards Oliver