From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Harish Jenny K N <harish_kandiga@mentor.com>,
Linus Walleij <linus.walleij@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
avri.altman@wdc.com,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Vladimir Zapolskiy <Vladimir_Zapolskiy@mentor.com>
Subject: Re: [PATCH v10] mmc: Export host capabilities to debugfs.
Date: Thu, 15 Mar 2018 15:02:08 +0200 [thread overview]
Message-ID: <1521118928.10722.658.camel@linux.intel.com> (raw)
In-Reply-To: <CAPDyKFrZaDx2NdvaFdgOxWBuwtjMnJE41p=x5b2x2moFEO3kXQ@mail.gmail.com>
On Thu, 2018-03-15 at 13:29 +0100, Ulf Hansson wrote:
> On 15 March 2018 at 11:26, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Thu, 2018-03-15 at 11:12 +0100, Ulf Hansson wrote:
> > > On 13 March 2018 at 06:10, Harish Jenny K N <harish_kandiga@mentor
> > > .com
> > > > wrote:
> > > >
> > > Honestly, I don't like this, but maybe other people do, then I am
> > > fine
> > > with this approach.
> > >
> > > If were to decide, I would just rather print the caps field in a
> > > hexadecimal bit form and leave the translation to the user.
> >
> > A compromise would be to print both:
> >
> > 0xHHHHHHHH\n
> > Description of each enabled field, one per line
> >
> >
> > Another format would be:
> >
> > Bit XX: Description of a field
>
> If we were to print the description, there is no point in printing the
> bits in hex. Or is it?
It is helpful for scripting (since it's debugfs, under scripting I mean
something rather for test suites than for actual use).
> As I said, if you and other folkz thinks this is valuable, then I am
> fine as well. Just saying, it's not my preferred option.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-03-15 13:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 5:10 [PATCH v10] mmc: Export host capabilities to debugfs Harish Jenny K N
2018-03-15 10:12 ` Ulf Hansson
2018-03-15 10:26 ` Andy Shevchenko
2018-03-15 12:29 ` Ulf Hansson
2018-03-15 13:02 ` Andy Shevchenko [this message]
2018-03-16 4:20 ` Harish Jenny K N
2018-03-16 7:57 ` Ulf Hansson
2018-03-22 5:19 ` Harish Jenny K N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521118928.10722.658.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Vladimir_Zapolskiy@mentor.com \
--cc=adrian.hunter@intel.com \
--cc=avri.altman@wdc.com \
--cc=harish_kandiga@mentor.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox