From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753000AbcJJOPx (ORCPT ); Mon, 10 Oct 2016 10:15:53 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:59693 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752360AbcJJOPR (ORCPT ); Mon, 10 Oct 2016 10:15:17 -0400 From: Arnd Bergmann To: Geert Uytterhoeven Cc: Simon Horman , Magnus Damm , Greg Kroah-Hartman , Yangbo Lu , Lee Jones , Dirk Behme , linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] base: soc: Check for NULL SoC device attributes Date: Mon, 10 Oct 2016 16:13:45 +0200 Message-ID: <1521283.2YYXpcZaoN@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1475572167-29581-4-git-send-email-geert+renesas@glider.be> References: <1475572167-29581-1-git-send-email-geert+renesas@glider.be> <1475572167-29581-4-git-send-email-geert+renesas@glider.be> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:tBMYzrbgpE5L4Mi1GoHf3D85uNAu+QbpS6GVYtRoVuOiAvXtMKq rgODOd/BFwEeWEzmhnct9DCEcME0q1ElSnNtac/CdZoQO/8oodMqvNbPs2kSJ3DNkSrgJID WRFxLUMezLaB+zM9zP4YmLSRZGdRrH/hJTgUJ9A8pRK6R6a/nUOIH9Rau3lDxMMnK2tHniu 5t6xADJRbZPtob9qGG6iA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Y3ZcmrjpJFc=:atg1vU/PxFvonkCVLrxI5K GvaInqqoITkj9W0Qx3cwKdk41J496u4whabVk2e40xASD8TP2Wy6Ua0n37fZk3g5lReAqdJk5 cfMc03mpxgHGTP/NiN4SBQCJqTv75lKouC3hYThMbS2XGfR6/Ucst1ISiLEZDueevV96SWTsp XLdnAnnGEs58tO8bOcslQf0rTtRSkJzJCXk3M0jZq0auiHFJGAyV4kIWsE+XKyEtRhltKsEqi OFr/P+vX1xzsCzRof8Gz59yjBNyIATAt3m2lvlXJepOPC0tPzKAIb/vAECJCFcLOar+FG+8Dt V5Ebw2l9l4PN+hpomXh0CeuvoZgS/NNTyDxmzx29Z8BmhsUMqrmv5bvXIwEbr2gcM+K1pPRPi loIXjyyLjvfJt5gP/ijMS0zSUal4oXY4S+JgJR3qyPpWldRSiRVjsjG4FerxY2PRKTqmiuo8f /ihYWPZgXB3vcMam+eFZADhmUpgmH40Ij8KqTouMioYUyCwkRyVzUB/IxEQQwQK9wZiT2kej7 hz4SaoJBnHBsSpagYDB+B0jAwnlOBuqYKAjY2TvPR3wepIt29Nm2qaCLz8wDplz97W+FVohdK 6rLPj1YbdKeiEPgYCf+kYrrJVt1bFDtSD8lzvWc0g4Vnr0TcA/E4HlL3AQKNwrUB7j5eNkqZl IuE2Mwn+M3b/79V82EgZSAEm0kC3iZucDJB1VwWoYNnfzxZ6WPXw+7p1Y3/8N2IM5t3HarlKV s/uJiEsJ3MRFss4+ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, October 4, 2016 11:09:26 AM CEST Geert Uytterhoeven wrote: > If soc_device_match() is used to check the value of a specific > attribute that is not present for the current SoC, the kernel crashes > with a NULL pointer dereference. > > Fix this by explicitly checking for the absence of a needed property, > and considering this a non-match. > > Signed-off-by: Geert Uytterhoeven > Acked-by: Arnd Bergmann