Re: [PATCH v6 21/21] perf-probe: Add array argument support

Masami Hiramatsu
2018-03-26T03:53:46Z

On Thu, 22 Mar 2018 16:19:46 +0530
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:

> Hi Masami :)
>
> On 03/22/2018 03:53 PM, Masami Hiramatsu wrote:
> > On Mon, 19 Mar 2018 13:29:59 +0530
> > Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:
> >
> >>
> >> Is it okay to allow user to specify array size with type field?
> > Fro this patch, yes.
>
> So IIUC, perf _tool_ will allow user to record array either with "name[range]"
> or by "name:type[length]". Please correct me if that's wrong.

Yes, it is correct.

> And If perf tool will allow array length along with TYPE field, I guess we should
> document that in man perf-probe?

Ah, right. OK, I'll add it.

Thanks!

>
> Otherwise,
>
> Acked-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
>
> Thanks,
> Ravi
>
> > The availability of type is checked only when
> > it is automatically generated.
> > IMO, it should be done in another patch, something like
> > "Validate user specified type casting" patch. Would you need it?
> >
> > Thank you,
> >
>

--
Masami Hiramatsu <mhiramat@kernel.org>