Re: [PATCH v6 05/21] tracing: probeevent: Cleanup print argument functions

Masami Hiramatsu
2018-03-26T04:17:37Z

On Fri, 23 Mar 2018 12:36:47 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Sat, 17 Mar 2018 21:41:12 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > Current print argument functions prints the argument
> > name too. It is not good for printing out multiple
> > values for one argument. This change it to just print
> > out the value.
>
> Hi Masami,
>
> This is a confusing change log, as I have no idea what this patch does.
> Can you add a "before" and "after" of what you mean. Some examples of
> what it currently does to show why it looks bad, and then an example of
> what it looks like after the patch.

OK, this is actually just a cleanup patch. No functional difference between
"before" and "after". For more flexible argument, like array type, we need
to decouple with argument name and its value printing. Is below more clear
to you?

Cleanup argument-printing functions to decouple it into name-printing and
value-printing, so that it can support more flexible argument expression,
like array type.

Thanks,

>
> Thanks!
>
> -- Steve
>
>
> >
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> >

--
Masami Hiramatsu <mhiramat@kernel.org>