From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752858AbeCVIme (ORCPT ); Thu, 22 Mar 2018 04:42:34 -0400 Received: from mail.bootlin.com ([62.4.15.54]:35809 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752597AbeCVIma (ORCPT ); Thu, 22 Mar 2018 04:42:30 -0400 Message-ID: <1521708064.1175.5.camel@bootlin.com> Subject: Re: [PATCH 03/10] drm/sun4i: Don't pretend to handle ARGB8888 with the frontend From: Paul Kocialkowski To: Chen-Yu Tsai Cc: David Airlie , linux-kernel , dri-devel , Daniel Vetter , Maxime Ripard , linux-arm-kernel Date: Thu, 22 Mar 2018 09:41:04 +0100 In-Reply-To: References: <20180321152904.22411-1-paul.kocialkowski@bootlin.com> <20180321152904.22411-4-paul.kocialkowski@bootlin.com> <1521706988.1175.4.camel@bootlin.com> Organization: Bootlin Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-6eUPk+5IRoBh/tsAocFC" X-Mailer: Evolution 3.26.5 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-6eUPk+5IRoBh/tsAocFC Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, On Thu, 2018-03-22 at 16:37 +0800, Chen-Yu Tsai wrote: > On Thu, Mar 22, 2018 at 4:23 PM, Paul Kocialkowski > wrote: > > Hi Chen-Yu, > >=20 > > On Thu, 2018-03-22 at 14:47 +0800, Chen-Yu Tsai wrote: > > > On Wed, Mar 21, 2018 at 11:28 PM, Paul Kocialkowski > > > wrote: > > > > It turns out that the frontend is not capable of preserving the > > > > alpha > > > > component (that is always set to 0xff), so only support XRGB8888 > > > > instead. > > > >=20 > > > > Signed-off-by: Paul Kocialkowski > > > > --- > > > > drivers/gpu/drm/sun4i/sun4i_backend.c | 4 ++++ > > > > drivers/gpu/drm/sun4i/sun4i_frontend.c | 3 +-- > > > > drivers/gpu/drm/sun4i/sun4i_layer.c | 4 ++-- > > > > 3 files changed, 7 insertions(+), 4 deletions(-) > > > >=20 > > > > diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c > > > > b/drivers/gpu/drm/sun4i/sun4i_backend.c > > > > index b98dafda52f8..274a1db6fa8e 100644 > > > > --- a/drivers/gpu/drm/sun4i/sun4i_backend.c > > > > +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c > > > > @@ -440,6 +440,10 @@ static bool > > > > sun4i_backend_plane_uses_frontend(struct drm_plane_state *state) > > > > if (IS_ERR(backend->frontend)) > > > > return false; > > > >=20 > > > > + /* > > > > + * TODO: Don't use the frontend for x2/x4 scaling and > > > > allow > > > > RGB formats > > > > + * with an alpha component then. > > >=20 > > > This and the commit log are kind of conflicting. Is it just the > > > scalar > > > that doesn't > > > work with an alpha component, or the whole frontend? > >=20 > > It's the whole frontend that does not support alpha in its output > > formats. I'm talking about scaling here because that's still the > > main > > reason to use the frontend. On the other hand, the backend allows > > integer scaling with an alpha component, hence the comment. >=20 > I see. I parsed the TODO note incorrectly. >=20 > > Do you think I need to rework the comment/commit log? >=20 > I think >=20 > Allow integer scaling with alpha using just the backend. >=20 > would be slightly clearer. I agree, will do in the next version! Cheers, Paul > > Thanks for the review, > >=20 > > Paul > >=20 > > > > + */ > > > > return sun4i_backend_plane_uses_scaler(state); > > > > } > > > >=20 > > > > diff --git a/drivers/gpu/drm/sun4i/sun4i_frontend.c > > > > b/drivers/gpu/drm/sun4i/sun4i_frontend.c > > > > index ddf6cfa6dd23..3ea925584891 100644 > > > > --- a/drivers/gpu/drm/sun4i/sun4i_frontend.c > > > > +++ b/drivers/gpu/drm/sun4i/sun4i_frontend.c > > > > @@ -107,7 +107,7 @@ EXPORT_SYMBOL(sun4i_frontend_update_buffer); > > > > static int sun4i_frontend_drm_format_to_input_fmt(uint32_t fmt, > > > > u32 > > > > *val) > > > > { > > > > switch (fmt) { > > > > - case DRM_FORMAT_ARGB8888: > > > > + case DRM_FORMAT_XRGB8888: > > > > *val =3D 5; > > > > return 0; > > > >=20 > > > > @@ -120,7 +120,6 @@ static int > > > > sun4i_frontend_drm_format_to_output_fmt(uint32_t fmt, u32 *val) > > > > { > > > > switch (fmt) { > > > > case DRM_FORMAT_XRGB8888: > > > > - case DRM_FORMAT_ARGB8888: > > > > *val =3D 2; > > > > return 0; > > > >=20 > > > > diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c > > > > b/drivers/gpu/drm/sun4i/sun4i_layer.c > > > > index eb93df445a10..15238211a61a 100644 > > > > --- a/drivers/gpu/drm/sun4i/sun4i_layer.c > > > > +++ b/drivers/gpu/drm/sun4i/sun4i_layer.c > > > > @@ -100,9 +100,9 @@ static void > > > > sun4i_backend_layer_atomic_update(struct drm_plane *plane, > > > > sun4i_frontend_update_coord(frontend, plane); > > > > sun4i_frontend_update_buffer(frontend, plane); > > > > sun4i_frontend_update_formats(frontend, plane, > > > > - DRM_FORMAT_ARGB888 > > > > 8); > > > > + DRM_FORMAT_XRGB888 > > > > 8); > > > > sun4i_backend_update_layer_frontend(backend, > > > > layer- > > > > > id, plane, > > > >=20 > > > > - DRM_FORMAT_A > > > > RGB8 > > > > 888); > > > > + DRM_FORMAT_X > > > > RGB8 > > > > 888); > > > > sun4i_frontend_enable(frontend); > > > > } else { > > > > sun4i_backend_update_layer_formats(backend, > > > > layer- > > > > > id, plane); > > > >=20 > > > > -- > > > > 2.16.2 > > > >=20 > > >=20 > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > >=20 > > -- > > Paul Kocialkowski, Bootlin (formerly Free Electrons) > > Embedded Linux and kernel engineering > > https://bootlin.com --=20 Paul Kocialkowski, Bootlin (formerly Free Electrons) Embedded Linux and kernel engineering https://bootlin.com --=-6eUPk+5IRoBh/tsAocFC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAlqzbCAACgkQ3cLmz3+f v9GaLgf9EnPfOVuClDJnlvI25X/gjTSOHNw6XK7TjQjs30UOaU7yng8gnRZkKZ2u RvNb6P+npWQrg72Sor2T/Bin9vx29qcY2+7ssX8wSkGicUKx/8/cYC8ZVFRRLfcA zSJzYdlqgsv7KSINeEkNdXUhwzSXvyVwexoiNg0XLQZX5uT8NHy9PTH/WFiQSdms I0JE+gmc/m5+3zb1XSqSj++vIyrF6HJJzPMyxSqbv8LgDFXGWeBmRAbTWLShObBf ELil5eAq/oAUB6rW93Rrbf7CovvTkPEZ/5nfQUfll9KB6eYnbFbe+fP7OrwMp12A SY8fFS+No5kIZQJH0Vn9tsXD0hMJSA== =6FFz -----END PGP SIGNATURE----- --=-6eUPk+5IRoBh/tsAocFC--