From: Joe Perches <joe@perches.com>
To: Alan Tull <atull@kernel.org>
Cc: Paolo Pisati <p.pisati@gmail.com>,
Moritz Fischer <mdf@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-fpga@vger.kernel.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support
Date: Thu, 22 Mar 2018 14:34:53 -0700 [thread overview]
Message-ID: <1521754493.7999.49.camel@perches.com> (raw)
In-Reply-To: <CANk1AXT6TY5N+gR=tBNuvhQMnOpuaWKWVoUSjB+Vfof2=GAM6w@mail.gmail.com>
On Thu, 2018-03-22 at 16:32 -0500, Alan Tull wrote:
> On Wed, Mar 21, 2018 at 1:04 PM, Joe Perches <joe@perches.com> wrote:
> > On Wed, 2018-03-21 at 18:35 +0100, Paolo Pisati wrote:
> > > This patch adds support to the FPGA manager for programming
> > > MachXO2 device’s internal flash memory, via slave SPI.
> >
> > style trivia:
> >
> > > diff --git a/drivers/fpga/machxo2-spi.c b/drivers/fpga/machxo2-spi.c
> >
> > []
> > > +static int get_status(struct spi_device *spi, unsigned long *status)
> > > +{
> > > + struct spi_message msg;
> > > + struct spi_transfer rx, tx;
> > > + u8 cmd[] = LSC_READ_STATUS;
> >
> > static const u8 cmd[]
> > here and everywhere else as all the tx_buf assignments
> > of cmd are to const void *
>
> Why *static* const u8 cmd[]?
So various compilers don't reload it on each call.
next prev parent reply other threads:[~2018-03-22 21:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 17:35 [PATCH 0/2 v7] Lattice MachXO2 Slave SPI FPGA Manager support Paolo Pisati
2018-03-21 17:35 ` [PATCH 1/2] dt: bindings: fpga: add lattice machxo2 slave spi binding description Paolo Pisati
2018-03-21 17:35 ` [PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support Paolo Pisati
2018-03-21 18:04 ` Joe Perches
2018-03-22 17:26 ` Paolo Pisati
2018-03-22 18:30 ` Joe Perches
2018-03-22 21:32 ` Alan Tull
2018-03-22 21:34 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-03-23 12:27 [PATCH 0/2 v8] Lattice MachXO2 Slave SPI FPGA Manager support Paolo Pisati
2018-03-23 12:27 ` [PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support Paolo Pisati
2018-03-28 16:26 ` Alan Tull
2018-03-28 20:03 ` Alan Tull
2018-03-29 14:33 ` Paolo Pisati
2018-03-16 15:54 [PATCH 0/2 v6] Lattice MachXO2 Slave SPI FPGA Manager support Paolo Pisati
2018-03-16 15:54 ` [PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support Paolo Pisati
2018-03-16 16:26 ` Moritz Fischer
2018-03-19 18:09 ` Paolo Pisati
2017-07-06 10:01 [PATCH v5 0/2] Lattice MachXO2 Slave SPI FPGA Manager support Paolo Pisati
2017-07-06 10:01 ` [PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support Paolo Pisati
2017-07-06 14:22 ` Moritz Fischer
2017-04-23 15:20 [PATCH 0/2] Lattice MachXO2 Passive SPI FPGA Manager support Paolo Pisati
2017-04-23 15:20 ` [PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support Paolo Pisati
2017-04-25 15:59 ` Alan Tull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521754493.7999.49.camel@perches.com \
--to=joe@perches.com \
--cc=atull@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mdf@kernel.org \
--cc=p.pisati@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox