From: Joe Perches <joe@perches.com>
To: Quytelda Kahja <quytelda@tamalin.org>
Cc: devel@driverdev.osuosl.org, Greg KH <gregkh@linuxfoundation.org>,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, wsa@the-dreams.de
Subject: Re: [PATCH 1/9] staging: ks7010: Replace manual array copy with ether_addr_copy().
Date: Thu, 29 Mar 2018 23:06:02 -0700 [thread overview]
Message-ID: <1522389962.2210.38.camel@perches.com> (raw)
In-Reply-To: <CAFLvi20F6HhQqunU2Pde6e4fahFHEnRW2sR-c6V0L-fbsMJQhA@mail.gmail.com>
On Thu, 2018-03-29 at 23:03 -0700, Quytelda Kahja wrote:
> If we just want to have the address field full of zeros during the
> driver probe, is there a reason we should zero it explicitly here?
> When the 'struct net_device' is first allocated using
> alloc_etherdev(), the dev_addr field is explicitly set to zeros (in
> the subfunction dev_addr_init() in net/core/dev_addr_lists.c), so it
> should be zeroed already at this point in the code.
You didn't describe the removal in your commit message
so it looked unintentional.
You should describe _why_ it's OK to remove it in that
commit message.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2018-03-30 6:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 5:51 [PATCH 1/9] staging: ks7010: Replace manual array copy with ether_addr_copy() Quytelda Kahja
2018-03-29 5:51 ` [PATCH 2/9] staging: ks7010: Remove unecessary cast Quytelda Kahja
2018-03-29 5:51 ` [PATCH 3/9] staging: ks7010: Reorder ks_wlan_netdev_ops members Quytelda Kahja
2018-03-29 9:46 ` Greg KH
2018-03-29 5:51 ` [PATCH 4/9] staging: ks7010: Rename ks_wlan_set_multicast_list() Quytelda Kahja
2018-03-29 5:51 ` [PATCH 5/9] staging: ks7010: Change mac_address_valid to a bool instead of int Quytelda Kahja
2018-03-29 5:51 ` [PATCH 6/9] staging: ks7010: Remove unused member 'reg_net' from 'ks_wlan_private' Quytelda Kahja
2018-03-29 5:51 ` [PATCH 7/9] staging: ks7010: Remove trailing "_t" from all structure names Quytelda Kahja
2018-03-29 9:51 ` Greg KH
2018-03-29 5:51 ` [PATCH 8/9] staging: ks7010: Remove 'eth_addr' field from 'struct ks_wlan_private' Quytelda Kahja
2018-03-29 5:51 ` [PATCH 9/9] staging: ks7010: Remove extra blank line between functions Quytelda Kahja
2018-03-29 6:15 ` Joe Perches
2018-03-29 6:02 ` [PATCH 1/9] staging: ks7010: Replace manual array copy with ether_addr_copy() Joe Perches
2018-03-30 6:03 ` Quytelda Kahja
2018-03-30 6:06 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522389962.2210.38.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quytelda@tamalin.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox