From: Jes Sorensen <jes@trained-monkey.org>
To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Cc: Ralf Baechle <ralf@uni-koblenz.de>, linux-kernel@vger.kernel.org
Subject: Re: [patch] dz.c 64 bit locking issues
Date: Fri, 17 Aug 2001 11:59:45 -0400 [thread overview]
Message-ID: <15229.16241.39447.219387@trained-monkey.org> (raw)
In-Reply-To: <Pine.GSO.3.96.1010817175020.16692A-100000@delta.ds2.pg.gda.pl>
In-Reply-To: <20010817164031.A6083@bacchus.dhis.org> <Pine.GSO.3.96.1010817175020.16692A-100000@delta.ds2.pg.gda.pl>
>>>>> "Maciej" == Maciej W Rozycki <macro@ds2.pg.gda.pl> writes:
Maciej> On Fri, 17 Aug 2001, Ralf Baechle wrote:
>> > The dz.c driver has an instance where it does save_flags() to a 32
>> bit > type which isn't safe for 64 bit boxen.
>>
>> It's safe because a MIPS only driver.
Maciej> Not necessarily. It might be safe now, but there is a
Maciej> TURBOchannel serial card with DZ11-compatible chipset that could
Maciej> be driven by the dz.c code after a few tweaks. And chances are
Maciej> someone will finish writing support for TURBOchannel Alphas one
Maciej> day...
Maciej> The change is harmless anyway.
Yep, I also think it's better for cosmetic reasons that we make all
drivers use unsigned long. That way the chance of someone else copying
bad code for a new driver is less likely.
Jes
next prev parent reply other threads:[~2001-08-17 16:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-16 4:26 [patch] dz.c 64 bit locking issues jes
2001-08-17 14:40 ` Ralf Baechle
2001-08-17 15:57 ` Maciej W. Rozycki
2001-08-17 15:59 ` Jes Sorensen [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-08-16 4:30 jes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15229.16241.39447.219387@trained-monkey.org \
--to=jes@trained-monkey.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@ds2.pg.gda.pl \
--cc=ralf@uni-koblenz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox