[patch] dz.c 64 bit locking issues

[patch] dz.c 64 bit locking issues

[jes]

Hi

The dz.c driver has an instance where it does save_flags() to a 32 bit
type which isn't safe for 64 bit boxen.

Jes

--- drivers/char/dz.c~	Wed Jul  4 17:41:33 2001
+++ drivers/char/dz.c	Thu Aug 16 00:24:48 2001
@@ -1279,7 +1279,8 @@
 
 int __init dz_init(void)
 {
-  int i, flags;
+  int i;
+  unsigned long flags;
   struct dz_serial *info;
 
   /* Setup base handler, and timer table. */

Re: [patch] dz.c 64 bit locking issues

[Ralf Baechle]

On Thu, Aug 16, 2001 at 12:26:36AM -0400, jes@trained-monkey.org wrote:

> The dz.c driver has an instance where it does save_flags() to a 32 bit
> type which isn't safe for 64 bit boxen.

It's safe because a MIPS only driver.

  Ralf

Re: [patch] dz.c 64 bit locking issues

[Maciej W. Rozycki]

On Fri, 17 Aug 2001, Ralf Baechle wrote:

> > The dz.c driver has an instance where it does save_flags() to a 32 bit
> > type which isn't safe for 64 bit boxen.
> 
> It's safe because a MIPS only driver.

 Not necessarily.  It might be safe now, but there is a TURBOchannel
serial card with DZ11-compatible chipset that could be driven by the dz.c
code after a few tweaks.  And chances are someone will finish writing
support for TURBOchannel Alphas one day...

 The change is harmless anyway.

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +

Re: [patch] dz.c 64 bit locking issues

[Jes Sorensen]

>>>>> "Maciej" == Maciej W Rozycki <macro@ds2.pg.gda.pl> writes:

Maciej> On Fri, 17 Aug 2001, Ralf Baechle wrote:
>> > The dz.c driver has an instance where it does save_flags() to a 32
>> bit > type which isn't safe for 64 bit boxen.
>> 
>> It's safe because a MIPS only driver.

Maciej>  Not necessarily.  It might be safe now, but there is a
Maciej> TURBOchannel serial card with DZ11-compatible chipset that could
Maciej> be driven by the dz.c code after a few tweaks.  And chances are
Maciej> someone will finish writing support for TURBOchannel Alphas one
Maciej> day...

Maciej>  The change is harmless anyway.

Yep, I also think it's better for cosmetic reasons that we make all
drivers use unsigned long. That way the chance of someone else copying
bad code for a new driver is less likely.

Jes

[patch] dz.c 64 bit locking issues

[jes]

Hi

Another 64 bit flags bug.

Cheers
Jes

--- drivers/char/n_r3964.c~	Wed Jun 27 17:13:01 2001
+++ drivers/char/n_r3964.c	Thu Aug 16 00:29:13 2001
@@ -1421,7 +1421,7 @@
    int pid=current->pid;
    struct r3964_client_info *pClient;
    struct r3964_message *pMsg=NULL;
-   unsigned int flags;
+   unsigned long flags;
    int result = POLLOUT;
 
    TRACE_L("POLL");