public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Petr Mladek <pmladek@suse.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	"Tobin C . Harding" <me@tobin.cc>,
	Andrew Morton <akpm@linux-foundation.org>,
	Michal Hocko <mhocko@suse.cz>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/9] vsprintf: Consolidate handling of unknown pointer specifiers
Date: Fri, 06 Apr 2018 07:27:19 -0700	[thread overview]
Message-ID: <1523024839.6127.9.camel@perches.com> (raw)
In-Reply-To: <741c7f99-e39e-296c-1b91-3df7113ee71c@rasmusvillemoes.dk>

On Fri, 2018-04-06 at 15:17 +0200, Rasmus Villemoes wrote:
> On 2018-04-06 13:43, Petr Mladek wrote:
> > On Thu 2018-04-05 16:55:35, Joe Perches wrote:
> > > On Thu, 2018-04-05 at 16:45 -0700, Joe Perches wrote:
> > > > On Thu, 2018-04-05 at 16:25 +0200, Rasmus Villemoes wrote:
> > > > > Even just git grep -1 -E '%p"$' finds %pt and %po
> > > > > which should get fixed before somebody claims those extensions.
> > > > 
> > > > Neither %pt nor %po is used in a vsprintf
> > > > in the kernel.
> > > 
> > > Nope, you are right, both are defectively used in the
> > > kernel via string concatenation.
> > 
> > Ah, I see.
> 
> Yes, that was the point of that particular grep pattern with context. I
> sent patches three years ago and several pings, but despite an email
> telling me it would be picked up "for the next release" nothing has
> happened, so I've just been waiting for someone to implement a %po.
> 
> > Otherwise, the changes make perfect sense. Are you going to send
> > them as proper patches, please?
> 
> Good luck. Unless Petr will be taking them through the printk tree?

As the trivial maintainer seems to use a leaky bucket algorithm
for most trivial patches, I'll just retry and send actual
patches through Andrew Morton as patches through his quilt tree
seem to get upstream faster.

And thanks Petr for noticing the missing __func__, I was just
mindlessly editing those two files as a placeholder for where
the missing spaces in the %p concatenations exist.

  reply	other threads:[~2018-04-06 14:27 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-04  8:58 [PATCH v4 0/9] vsprintf: Prevent silent crashes and consolidate error handling Petr Mladek
2018-04-04  8:58 ` [PATCH v4 1/9] vsprintf: Shuffle ptr_to_id() code Petr Mladek
2018-04-04  8:58 ` [PATCH v4 2/9] vsprintf: Consistent %pK handling for kptr_restrict == 0 Petr Mladek
2018-04-04 23:10   ` Sergey Senozhatsky
2018-04-05 14:34     ` Petr Mladek
2018-04-05 13:04   ` Andy Shevchenko
2018-04-05 14:46     ` Petr Mladek
2018-04-07 14:08       ` Andy Shevchenko
2018-04-09 12:05         ` Petr Mladek
2018-04-09 12:11           ` Andy Shevchenko
2018-04-04  8:58 ` [PATCH v4 3/9] vsprintf: Do not check address of well-known strings Petr Mladek
2018-04-05 13:30   ` Rasmus Villemoes
2018-04-06  9:15     ` Petr Mladek
2018-04-07 14:12       ` Andy Shevchenko
2018-04-09 12:19         ` Petr Mladek
2018-04-10 10:05           ` Andy Shevchenko
2018-04-04  8:58 ` [PATCH v4 4/9] vsprintf: Consolidate handling of unknown pointer specifiers Petr Mladek
2018-04-05 14:25   ` Rasmus Villemoes
2018-04-05 23:45     ` Joe Perches
2018-04-05 23:55       ` Joe Perches
2018-04-06 11:43         ` Petr Mladek
2018-04-06 13:17           ` Rasmus Villemoes
2018-04-06 14:27             ` Joe Perches [this message]
2018-04-09 12:30               ` Petr Mladek
2018-04-07 14:23             ` Andy Shevchenko
2018-04-06 23:52         ` Sergey Senozhatsky
2018-04-06 23:59           ` Joe Perches
2018-04-07  0:33             ` Sergey Senozhatsky
2018-04-07  1:00               ` Joe Perches
2018-04-07  1:17                 ` Sergey Senozhatsky
2018-04-06 11:25     ` Petr Mladek
2018-04-07 14:26   ` Andy Shevchenko
2018-04-09 13:50     ` Petr Mladek
2018-04-10 11:41       ` Andy Shevchenko
2018-04-11  9:52         ` Petr Mladek
2018-04-24 16:47           ` Andy Shevchenko
2018-04-04  8:58 ` [PATCH v4 5/9] vsprintf: Factor out %p[iI] handler as ip_addr_string() Petr Mladek
2018-04-04 23:58   ` Sergey Senozhatsky
2018-04-05 14:14     ` Petr Mladek
2018-04-07 14:30   ` Andy Shevchenko
2018-04-04  8:58 ` [PATCH v4 6/9] vsprintf: Factor out %pV handler as va_format() Petr Mladek
2018-04-04 14:26   ` Joe Perches
2018-04-06 13:12     ` Petr Mladek
2018-04-06 14:19       ` Joe Perches
2018-04-09 11:44         ` Petr Mladek
2018-04-09 11:59           ` Joe Perches
2018-04-04  8:58 ` [PATCH v4 7/9] vsprintf: Factor out %pO handler as kobject_string() Petr Mladek
2018-04-04 23:35   ` Sergey Senozhatsky
2018-04-04 23:43     ` Sergey Senozhatsky
2018-04-05 14:02     ` Petr Mladek
2018-04-04  8:58 ` [PATCH v4 8/9] vsprintf: Prevent crash when dereferencing invalid pointers Petr Mladek
2018-04-05 14:46   ` Rasmus Villemoes
2018-04-06 12:26     ` Petr Mladek
2018-04-06 13:12       ` Rasmus Villemoes
2018-04-10 13:26         ` Petr Mladek
2018-04-06  9:37   ` Rasmus Villemoes
2018-04-04  8:58 ` [PATCH v4 9/9] vsprintf: Avoid confusion between invalid address and value Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1523024839.6127.9.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=me@tobin.cc \
    --cc=mhocko@suse.cz \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox