From: "Raslan, KarimAllah" <karahmed@amazon.de>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"hpa@zytor.com" <hpa@zytor.com>,
"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] X86/VMX: Disable VMX preempition timer if MWAIT is not intercepted
Date: Tue, 10 Apr 2018 10:09:52 +0000 [thread overview]
Message-ID: <1523354992.5178.6.camel@amazon.de> (raw)
In-Reply-To: <2cd149f0-6ebe-59fc-addb-8b4b05e07d80@redhat.com>
On Tue, 2018-04-10 at 11:04 +0200, Paolo Bonzini wrote:
> On 10/04/2018 10:50, KarimAllah Ahmed wrote:
> >
> > WARN_ON(preemptible());
> > - if (!kvm_x86_ops->set_hv_timer)
> > + if (!kvm_x86_ops->has_hv_timer ||
> > + !kvm_x86_ops->has_hv_timer(apic->vcpu))
> > return false;
> >
> > if (!apic_lvtt_period(apic) && atomic_read(&ktimer->pending))
>
> Why not just return -ENOTSUP from vmx_set_hv_timer?
hehe .. good point :)
I just sent v2!
>
> Thanks,
>
> Paolo
>
Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B
prev parent reply other threads:[~2018-04-10 10:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 8:50 [PATCH] X86/VMX: Disable VMX preempition timer if MWAIT is not intercepted KarimAllah Ahmed
2018-04-10 9:04 ` Paolo Bonzini
2018-04-10 10:09 ` Raslan, KarimAllah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1523354992.5178.6.camel@amazon.de \
--to=karahmed@amazon.de \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox