* [PATCH] staging: wilc1000: Remove unnecessary braces {} around single statement block
@ 2018-04-10 14:49 Eyal Ilsar
2018-04-12 7:43 ` Claudiu Beznea
2018-04-12 7:59 ` [PATCH v2] " Eyal Ilsar
0 siblings, 2 replies; 4+ messages in thread
From: Eyal Ilsar @ 2018-04-10 14:49 UTC (permalink / raw)
To: aditya.shankar, ganesh.krishna, gregkh
Cc: devel, linux-wireless, linux-kernel
Remove unnecessary braces {} around an 'if' statement block with a single
statement. Issue found by checkpatch.
Signed-off-by: Eyal Ilsar<edilsar@gmail.com>
---
This is part of my take on the Eudyptula challenge
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
index 205304c..325afe1 100644
--- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
+++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
@@ -284,9 +284,8 @@ static void remove_network_from_shadow(struct timer_list *unused)
}
}
- if (last_scanned_cnt != 0) {
+ if (last_scanned_cnt != 0)
mod_timer(&hAgingTimer, jiffies + msecs_to_jiffies(AGING_TIME));
- }
}
static void clear_duringIP(struct timer_list *unused)
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] staging: wilc1000: Remove unnecessary braces {} around single statement block
2018-04-10 14:49 [PATCH] staging: wilc1000: Remove unnecessary braces {} around single statement block Eyal Ilsar
@ 2018-04-12 7:43 ` Claudiu Beznea
2018-04-12 7:59 ` [PATCH v2] " Eyal Ilsar
1 sibling, 0 replies; 4+ messages in thread
From: Claudiu Beznea @ 2018-04-12 7:43 UTC (permalink / raw)
To: Eyal Ilsar, aditya.shankar, ganesh.krishna, gregkh
Cc: devel, linux-wireless, linux-kernel
On 10.04.2018 17:49, Eyal Ilsar wrote:
> Remove unnecessary braces {} around an 'if' statement block with a single
> statement. Issue found by checkpatch.
You should add an empty line before "Signed-off" line as stated in [1]. I
would also add a space b/w your name and your email in Signed-off line as
is exemplified in [2].
[1]
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format
[2] https://www.kernel.org/doc/html/latest/process/sub
mitting-patches.html#developer-s-certificate-of-origin-1-1
> Signed-off-by: Eyal Ilsar<edilsar@gmail.com>
> ---
> This is part of my take on the Eudyptula challenge
>
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> index 205304c..325afe1 100644
> --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> @@ -284,9 +284,8 @@ static void remove_network_from_shadow(struct timer_list *unused)
> }
> }
>
> - if (last_scanned_cnt != 0) {
> + if (last_scanned_cnt != 0)
> mod_timer(&hAgingTimer, jiffies + msecs_to_jiffies(AGING_TIME));
> - }
> }
>
> static void clear_duringIP(struct timer_list *unused)
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] staging: wilc1000: Remove unnecessary braces {} around single statement block
2018-04-10 14:49 [PATCH] staging: wilc1000: Remove unnecessary braces {} around single statement block Eyal Ilsar
2018-04-12 7:43 ` Claudiu Beznea
@ 2018-04-12 7:59 ` Eyal Ilsar
2018-04-12 8:16 ` Claudiu Beznea
1 sibling, 1 reply; 4+ messages in thread
From: Eyal Ilsar @ 2018-04-12 7:59 UTC (permalink / raw)
To: aditya.shankar, ganesh.krishna, gregkh
Cc: devel, linux-wireless, linux-kernel
Remove unnecessary braces {} around an 'if' statement block with a single
statement. Issue found by checkpatch.
Signed-off-by: Eyal Ilsar <edilsar@gmail.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
Added an empty line before the 'Signed-off-by' line and a space between the
name and e-mail address within that line.
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
index 205304c..325afe1 100644
--- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
+++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
@@ -284,9 +284,8 @@ static void remove_network_from_shadow(struct timer_list *unused)
}
}
- if (last_scanned_cnt != 0) {
+ if (last_scanned_cnt != 0)
mod_timer(&hAgingTimer, jiffies + msecs_to_jiffies(AGING_TIME));
- }
}
static void clear_duringIP(struct timer_list *unused)
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] staging: wilc1000: Remove unnecessary braces {} around single statement block
2018-04-12 7:59 ` [PATCH v2] " Eyal Ilsar
@ 2018-04-12 8:16 ` Claudiu Beznea
0 siblings, 0 replies; 4+ messages in thread
From: Claudiu Beznea @ 2018-04-12 8:16 UTC (permalink / raw)
To: Eyal Ilsar, aditya.shankar, ganesh.krishna, gregkh
Cc: devel, linux-wireless, linux-kernel
On 12.04.2018 10:59, Eyal Ilsar wrote:
> Remove unnecessary braces {} around an 'if' statement block with a single
> statement. Issue found by checkpatch.
>
> Signed-off-by: Eyal Ilsar <edilsar@gmail.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> Added an empty line before the 'Signed-off-by' line and a space between the
> name and e-mail address within that line.
>
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> index 205304c..325afe1 100644
> --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> @@ -284,9 +284,8 @@ static void remove_network_from_shadow(struct timer_list *unused)
> }
> }
>
> - if (last_scanned_cnt != 0) {
> + if (last_scanned_cnt != 0)
> mod_timer(&hAgingTimer, jiffies + msecs_to_jiffies(AGING_TIME));
> - }
> }
>
> static void clear_duringIP(struct timer_list *unused)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-12 8:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-10 14:49 [PATCH] staging: wilc1000: Remove unnecessary braces {} around single statement block Eyal Ilsar
2018-04-12 7:43 ` Claudiu Beznea
2018-04-12 7:59 ` [PATCH v2] " Eyal Ilsar
2018-04-12 8:16 ` Claudiu Beznea
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox