From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752710AbeDRGWD (ORCPT ); Wed, 18 Apr 2018 02:22:03 -0400 Received: from gate.crashing.org ([63.228.1.57]:58862 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752568AbeDRGWB (ORCPT ); Wed, 18 Apr 2018 02:22:01 -0400 Message-ID: <1524032458.11062.323.camel@kernel.crashing.org> Subject: Re: [PATCH] locking/rwsem: Synchronize task state & waiter->task of readers From: Benjamin Herrenschmidt To: Waiman Long , Peter Zijlstra , Ingo Molnar Cc: linux-kernel@vger.kernel.org, Dave Chinner , Eric Sandeen , "Paul E. McKenney" Date: Wed, 18 Apr 2018 16:20:58 +1000 In-Reply-To: <1523380938-19462-1-git-send-email-longman@redhat.com> References: <1523380938-19462-1-git-send-email-longman@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 (3.26.6-1.fc27) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2018-04-10 at 13:22 -0400, Waiman Long wrote: > It was observed occasionally in PowerPC systems that there was reader > who had not been woken up but that its waiter->task had been cleared. > > One probable cause of this missed wakeup may be the fact that the > waiter->task and the task state have not been properly synchronized as > the lock release-acquire pair of different locks in the wakeup code path > does not provide a full memory barrier guarantee. So smp_store_mb() > is now used to set waiter->task to NULL to provide a proper memory > barrier for synchronization. > > Signed-off-by: Waiman Long That looks right... nothing in either lock or unlock will prevent a store going past a load. > --- > kernel/locking/rwsem-xadd.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/kernel/locking/rwsem-xadd.c b/kernel/locking/rwsem-xadd.c > index e795908..b3c588c 100644 > --- a/kernel/locking/rwsem-xadd.c > +++ b/kernel/locking/rwsem-xadd.c > @@ -209,6 +209,23 @@ static void __rwsem_mark_wake(struct rw_semaphore *sem, > smp_store_release(&waiter->task, NULL); > } > > + /* > + * To avoid missed wakeup of reader, we need to make sure > + * that task state and waiter->task are properly synchronized. > + * > + * wakeup sleep > + * ------ ----- > + * __rwsem_mark_wake: rwsem_down_read_failed*: > + * [S] waiter->task [S] set_current_state(state) > + * MB MB > + * try_to_wake_up: > + * [L] state [L] waiter->task > + * > + * For the wakeup path, the original lock release-acquire pair > + * does not provide enough guarantee of proper synchronization. > + */ > + smp_mb(); > + > adjustment = woken * RWSEM_ACTIVE_READ_BIAS - adjustment; > if (list_empty(&sem->wait_list)) { > /* hit end of list above */