Re: [PATCH 41/61] power: supply: simplify getting .drvdata

Sebastian Reichel
2018-04-25T21:16:33Z

[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]

Hi,

On Thu, Apr 19, 2018 at 04:06:11PM +0200, Wolfram Sang wrote:
> We should get drvdata from struct device directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---

Thanks, queued.

-- Sebastian

>
> Build tested only. buildbot is happy. Please apply individually.
>
> drivers/power/supply/gpio-charger.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/power/supply/gpio-charger.c b/drivers/power/supply/gpio-charger.c
> index bd2468ca6b63..c3f2a9479468 100644
> --- a/drivers/power/supply/gpio-charger.c
> +++ b/drivers/power/supply/gpio-charger.c
> @@ -212,8 +212,7 @@ static int gpio_charger_suspend(struct device *dev)
>
> static int gpio_charger_resume(struct device *dev)
> {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct gpio_charger *gpio_charger = platform_get_drvdata(pdev);
> + struct gpio_charger *gpio_charger = dev_get_drvdata(dev);
>
> if (device_may_wakeup(dev) && gpio_charger->wakeup_enabled)
> disable_irq_wake(gpio_charger->irq);
> --
> 2.11.0
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]