From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932148AbeDZPUH (ORCPT ); Thu, 26 Apr 2018 11:20:07 -0400 Received: from smtp.nue.novell.com ([195.135.221.5]:43414 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756204AbeDZPUC (ORCPT ); Thu, 26 Apr 2018 11:20:02 -0400 Message-ID: <1524476031.2075.24.camel@suse.com> Subject: Re: [PATCH v3 0/6] scsi: handle special return codes for ABORTED COMMAND From: Martin Wilck To: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Hannes Reinecke , James Bottomley , Xose Vazquez Perez , Bart Van Assche In-Reply-To: References: <20180417233511.6573-1-mwilck@suse.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 23 Apr 2018 11:33:51 +0200 Mime-Version: 1.0 X-Mailer: Evolution 3.28.1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2018-04-20 at 19:15 -0400, Martin K. Petersen wrote: > > Much better, thanks for reworking this. Applied to 4.18/scsi-queue. Thank you! By the way, I've been wondering whether declaring blist_flags_t __bitwise was a wise decision. blist_flags_t is kernel-internal, thus endianness doesn't matter. OTOH, using __bitwise requires explicit casts in many places, which may suppress warnings about integer size mismatch and made me overlook some places where I had to change "unsigned long" to "unsigned long long" in the first place (in the submitted and applied version I think I caught them all). Regards, Martin -- Dr. Martin Wilck , Tel. +49 (0)911 74053 2107 SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)