Re: [PATCH] Always report a writeback error once

Andres Freund
2018-04-23T21:53:28Z

On 2018-04-23 14:51:50 -0700, Matthew Wilcox wrote:
> How does this look?
>
> @@ -111,27 +111,22 @@ EXPORT_SYMBOL(errseq_set);
> * errseq_sample() - Grab current errseq_t value.
> * @eseq: Pointer to errseq_t to be sampled.
> *
> - * This function allows callers to sample an errseq_t value, marking it as
> - * "seen" if required.
> + * This function allows callers to initialise their errseq_t variable.
> + * If the error has been "seen", new callers will not see an old error.
> + * If there is an unseen error in @eseq, the caller of this function will
> + * see it the next time it checks for an error.
> *
> + * Context: Any context.
> * Return: The current errseq value.
> */
> errseq_t errseq_sample(errseq_t *eseq)

LGTM.