Re: [PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode

Andy Shevchenko
2018-05-07T14:08:56Z

On Sat, Apr 28, 2018 at 12:50 AM, Antonio Rosario Intilisano
<antonio.intilisano@gmail.com> wrote:
> Now that we have informed the firmware that the Power Button driver is
> active, laptops such as the Acer Swift 3 will generate
> a WMI key event with code 0x87 when the power button key is
> pressed.
>
> Add this keycode to the table so that it is converted to an appropriate
> input event.

I pushed it to my review and testing queue, thanks!

Though, see below.

>
> Signed-off-by: Antonio Rosario Intilisano <antonio.intilisano@gmail.com>
> Acked-by: Gianfranco Costamagna <locutusofborg@debian.org>
> Tested-by: Antonio Rosario Intilisano <antonio.intilisano@gmail.com>
> Cc: Chris Chiu <chiu@endlessm.com>
> Cc: Daniel Drake <drake@endlessm.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> ---
> drivers/platform/x86/acer-wmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 1be71f956d5c..8952173dd380 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -129,6 +129,7 @@ static const struct key_entry acer_wmi_keymap[] __initconst = { {KE_IGNORE, 0x83, {KEY_TOUCHPAD_TOGGLE} },

This is malformed patch. It states 6 lines for context, though only 4
provided. Please, fix your tools.

> {KE_KEY, 0x85, {KEY_TOUCHPAD_TOGGLE} },
> {KE_KEY, 0x86, {KEY_WLAN} },
> + {KE_KEY, 0x87, {KEY_POWER} },
> {KE_END, 0}
> };
>
> --
> 2.15.1
>

--
With Best Regards,
Andy Shevchenko