From: Ilya Dryomov <idryomov@gmail.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] iov_iter: fix memory leak in pipe_get_pages_alloc()
Date: Wed, 2 May 2018 20:16:57 +0200 [thread overview]
Message-ID: <1525285017-18616-2-git-send-email-idryomov@gmail.com> (raw)
In-Reply-To: <1525285017-18616-1-git-send-email-idryomov@gmail.com>
Make n signed to avoid leaking the pages array if __pipe_get_pages()
fails.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
---
lib/iov_iter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/iov_iter.c b/lib/iov_iter.c
index 4d5bf40d399d..fdae394172fa 100644
--- a/lib/iov_iter.c
+++ b/lib/iov_iter.c
@@ -1102,7 +1102,7 @@ static ssize_t pipe_get_pages_alloc(struct iov_iter *i,
size_t *start)
{
struct page **p;
- size_t n;
+ ssize_t n;
int idx;
int npages;
--
2.4.3
next prev parent reply other threads:[~2018-05-02 18:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 18:16 [PATCH 1/2] iov_iter: fix return type of __pipe_get_pages() Ilya Dryomov
2018-05-02 18:16 ` Ilya Dryomov [this message]
2018-05-02 18:40 ` [PATCH 2/2] iov_iter: fix memory leak in pipe_get_pages_alloc() Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525285017-18616-2-git-send-email-idryomov@gmail.com \
--to=idryomov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox