From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751731AbeEBVEM (ORCPT ); Wed, 2 May 2018 17:04:12 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:34031 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751503AbeEBVEJ (ORCPT ); Wed, 2 May 2018 17:04:09 -0400 X-Google-Smtp-Source: AB8JxZoemIriATh0eRCBRzH9d6nnf5eYsLthvfwsoEa2caP6u3nhYTOFqKsQcOkO7gO4xUS3SpPF0g== Message-ID: <1525295047.30573.1.camel@redhat.com> Subject: Re: [PATCH] scsi: qla2xxx: remove the unused tcm_qla2xxx_cmd_wq From: Laurence Oberman To: Andrei Vagin , qla2xxx-upstream@qlogic.com Cc: linux-scsi@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , linux-kernel@vger.kernel.org Date: Wed, 02 May 2018 17:04:07 -0400 In-Reply-To: <20180502203113.13183-1-avagin@openvz.org> References: <20180502203113.13183-1-avagin@openvz.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2018-05-02 at 13:31 -0700, Andrei Vagin wrote: > Signed-off-by: Andrei Vagin > --- >  drivers/scsi/qla2xxx/tcm_qla2xxx.c | 10 ---------- >  1 file changed, 10 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c > b/drivers/scsi/qla2xxx/tcm_qla2xxx.c > index aadfeaac3898..b63440fec18e 100644 > --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c > +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c > @@ -48,7 +48,6 @@ >  #include "tcm_qla2xxx.h" >   >  static struct workqueue_struct *tcm_qla2xxx_free_wq; > -static struct workqueue_struct *tcm_qla2xxx_cmd_wq; >   >  /* >   * Parse WWN. > @@ -1976,16 +1975,8 @@ static int tcm_qla2xxx_register_configfs(void) >   goto out_fabric_npiv; >   } >   > - tcm_qla2xxx_cmd_wq = alloc_workqueue("tcm_qla2xxx_cmd", 0, > 0); > - if (!tcm_qla2xxx_cmd_wq) { > - ret = -ENOMEM; > - goto out_free_wq; > - } > - >   return 0; >   > -out_free_wq: > - destroy_workqueue(tcm_qla2xxx_free_wq); >  out_fabric_npiv: >   target_unregister_template(&tcm_qla2xxx_npiv_ops); >  out_fabric: > @@ -1995,7 +1986,6 @@ static int tcm_qla2xxx_register_configfs(void) >   >  static void tcm_qla2xxx_deregister_configfs(void) >  { > - destroy_workqueue(tcm_qla2xxx_cmd_wq); >   destroy_workqueue(tcm_qla2xxx_free_wq); >   >   target_unregister_template(&tcm_qla2xxx_ops); When I first saw this I thought, no way, it must be used, but when I had a closer look and checked its indeed not used or even made external. This looks OK to me. Reviewed-by: Laurence Oberman