* [PATCH] scsi: qla2xxx: remove the unused tcm_qla2xxx_cmd_wq
@ 2018-05-02 20:31 Andrei Vagin
2018-05-02 21:04 ` Laurence Oberman
2018-05-08 5:25 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Andrei Vagin @ 2018-05-02 20:31 UTC (permalink / raw)
To: qla2xxx-upstream
Cc: linux-scsi, James E.J. Bottomley, Martin K. Petersen,
linux-kernel, Andrei Vagin
Signed-off-by: Andrei Vagin <avagin@openvz.org>
---
drivers/scsi/qla2xxx/tcm_qla2xxx.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
index aadfeaac3898..b63440fec18e 100644
--- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
+++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
@@ -48,7 +48,6 @@
#include "tcm_qla2xxx.h"
static struct workqueue_struct *tcm_qla2xxx_free_wq;
-static struct workqueue_struct *tcm_qla2xxx_cmd_wq;
/*
* Parse WWN.
@@ -1976,16 +1975,8 @@ static int tcm_qla2xxx_register_configfs(void)
goto out_fabric_npiv;
}
- tcm_qla2xxx_cmd_wq = alloc_workqueue("tcm_qla2xxx_cmd", 0, 0);
- if (!tcm_qla2xxx_cmd_wq) {
- ret = -ENOMEM;
- goto out_free_wq;
- }
-
return 0;
-out_free_wq:
- destroy_workqueue(tcm_qla2xxx_free_wq);
out_fabric_npiv:
target_unregister_template(&tcm_qla2xxx_npiv_ops);
out_fabric:
@@ -1995,7 +1986,6 @@ static int tcm_qla2xxx_register_configfs(void)
static void tcm_qla2xxx_deregister_configfs(void)
{
- destroy_workqueue(tcm_qla2xxx_cmd_wq);
destroy_workqueue(tcm_qla2xxx_free_wq);
target_unregister_template(&tcm_qla2xxx_ops);
--
2.14.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: qla2xxx: remove the unused tcm_qla2xxx_cmd_wq
2018-05-02 20:31 [PATCH] scsi: qla2xxx: remove the unused tcm_qla2xxx_cmd_wq Andrei Vagin
@ 2018-05-02 21:04 ` Laurence Oberman
2018-05-08 5:25 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Laurence Oberman @ 2018-05-02 21:04 UTC (permalink / raw)
To: Andrei Vagin, qla2xxx-upstream
Cc: linux-scsi, James E.J. Bottomley, Martin K. Petersen,
linux-kernel
On Wed, 2018-05-02 at 13:31 -0700, Andrei Vagin wrote:
> Signed-off-by: Andrei Vagin <avagin@openvz.org>
> ---
> drivers/scsi/qla2xxx/tcm_qla2xxx.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
> b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
> index aadfeaac3898..b63440fec18e 100644
> --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
> +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
> @@ -48,7 +48,6 @@
> #include "tcm_qla2xxx.h"
>
> static struct workqueue_struct *tcm_qla2xxx_free_wq;
> -static struct workqueue_struct *tcm_qla2xxx_cmd_wq;
>
> /*
> * Parse WWN.
> @@ -1976,16 +1975,8 @@ static int tcm_qla2xxx_register_configfs(void)
> goto out_fabric_npiv;
> }
>
> - tcm_qla2xxx_cmd_wq = alloc_workqueue("tcm_qla2xxx_cmd", 0,
> 0);
> - if (!tcm_qla2xxx_cmd_wq) {
> - ret = -ENOMEM;
> - goto out_free_wq;
> - }
> -
> return 0;
>
> -out_free_wq:
> - destroy_workqueue(tcm_qla2xxx_free_wq);
> out_fabric_npiv:
> target_unregister_template(&tcm_qla2xxx_npiv_ops);
> out_fabric:
> @@ -1995,7 +1986,6 @@ static int tcm_qla2xxx_register_configfs(void)
>
> static void tcm_qla2xxx_deregister_configfs(void)
> {
> - destroy_workqueue(tcm_qla2xxx_cmd_wq);
> destroy_workqueue(tcm_qla2xxx_free_wq);
>
> target_unregister_template(&tcm_qla2xxx_ops);
When I first saw this I thought, no way, it must be used, but when I
had a closer look and checked its indeed not used or even made
external.
This looks OK to me.
Reviewed-by: Laurence Oberman <loberman@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: qla2xxx: remove the unused tcm_qla2xxx_cmd_wq
2018-05-02 20:31 [PATCH] scsi: qla2xxx: remove the unused tcm_qla2xxx_cmd_wq Andrei Vagin
2018-05-02 21:04 ` Laurence Oberman
@ 2018-05-08 5:25 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2018-05-08 5:25 UTC (permalink / raw)
To: Andrei Vagin
Cc: qla2xxx-upstream, linux-scsi, James E.J. Bottomley,
Martin K. Petersen, linux-kernel
Andrei,
Applied to 4.18/scsi-queue. thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-08 5:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-02 20:31 [PATCH] scsi: qla2xxx: remove the unused tcm_qla2xxx_cmd_wq Andrei Vagin
2018-05-02 21:04 ` Laurence Oberman
2018-05-08 5:25 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox