From: Ching Huang <ching2048@areca.com.tw>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
dan.carpenter@oracle.com, hch@infradead.org,
colin.king@canonical.com
Subject: Re: [PATCH 0/3] scsi: arcmsr: Add driver parameter cmd_timeout for scsi command timeout setting
Date: Tue, 08 May 2018 14:43:38 +0800 [thread overview]
Message-ID: <1525761818.4261.12.camel@Centos6.3-64> (raw)
In-Reply-To: <1525761166.4261.8.camel@Centos6.3-64>
On Tue, 2018-05-08 at 14:32 +0800, Ching Huang wrote:
> On Tue, 2018-05-08 at 01:41 -0400, Martin K. Petersen wrote:
> > Hello Ching,
> >
> > > 1. Add driver parameter cmd_timeout, default value is ARCMSR_DEFAULT_TIMEOUT.
> > > 2. Add slave_configure callback function to set device command timeout value.
> > > 3. Update driver version to v1.40.00.06-20180504.
> >
> > I am not so keen on arcmsr overriding the timeout set by the admin or
> > application.
> >
> > Also, instead of introducing this module parameter, why not simply ask
> > the user to change rq_timeout?
> >
> This timeout setting only after device has been inquiry successfully.
> Of course, user can set timeout value to /sys/block/sdX/device/timeout.
> But user does not like to set this value once command timeout occurred.
> They rather like timeout never happen.
>
This timeout setting apply to all devices, its better than user has to
set one bye one for each device.
next prev parent reply other threads:[~2018-05-08 6:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 6:43 [PATCH 0/3] scsi: arcmsr: Add driver parameter cmd_timeout for scsi command timeout setting Ching Huang
2018-05-08 5:41 ` Martin K. Petersen
2018-05-08 6:32 ` Ching Huang
2018-05-08 6:43 ` Ching Huang [this message]
2018-05-09 9:05 ` Steffen Maier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525761818.4261.12.camel@Centos6.3-64 \
--to=ching2048@areca.com.tw \
--cc=James.Bottomley@HansenPartnership.com \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox