From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756285AbeEHSgs (ORCPT ); Tue, 8 May 2018 14:36:48 -0400 Received: from mga02.intel.com ([134.134.136.20]:62098 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756059AbeEHSgq (ORCPT ); Tue, 8 May 2018 14:36:46 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,379,1520924400"; d="scan'208";a="52606104" Message-ID: <1525804604.49308.15.camel@linux.intel.com> Subject: Re: [PATCH] Documentation/admin-guide/pm/intel_pstate: fix Active Mode w/o HWP paragraph From: Srinivas Pandruvada To: Juri Lelli , linux-kernel@vger.kernel.org Cc: Jonathan Corbet , "Rafael J. Wysocki" , linux-doc@vger.kernel.org, linux-pm@vger.kernel.org Date: Tue, 08 May 2018 11:36:44 -0700 In-Reply-To: <20180508151209.9314-1-juri.lelli@redhat.com> References: <20180508151209.9314-1-juri.lelli@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.24.6 (3.24.6-1.fc26) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2018-05-08 at 17:12 +0200, Juri Lelli wrote: > P-state selection algorithm (powersave or performance) is selected by > echoing the desired choice to scaling_governor sysfs attribute and > not > to scaling_cur_freq (as currently stated). > > Fix it. Thanks for the fix. > > Signed-off-by: Juri Lelli > Cc: Jonathan Corbet > Cc: "Rafael J. Wysocki" > Cc: Srinivas Pandruvada > Cc: linux-doc@vger.kernel.org > Cc: linux-pm@vger.kernel.org Reviewed-by: Srinivas Pandruvada > > --- > Documentation/admin-guide/pm/intel_pstate.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/admin-guide/pm/intel_pstate.rst > b/Documentation/admin-guide/pm/intel_pstate.rst > index d2b6fda3d67b..ab2fe0eda1d7 100644 > --- a/Documentation/admin-guide/pm/intel_pstate.rst > +++ b/Documentation/admin-guide/pm/intel_pstate.rst > @@ -145,7 +145,7 @@ feature enabled.] > > In this mode ``intel_pstate`` registers utilization update callbacks > with the > CPU scheduler in order to run a P-state selection algorithm, either > -``powersave`` or ``performance``, depending on the > ``scaling_cur_freq`` policy > +``powersave`` or ``performance``, depending on the > ``scaling_governor`` policy > setting in ``sysfs``. The current CPU frequency information to be > made > available from the ``scaling_cur_freq`` policy attribute in > ``sysfs`` is > periodically updated by those utilization update callbacks too.