From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752083AbeEPPjk (ORCPT ); Wed, 16 May 2018 11:39:40 -0400 Received: from mga06.intel.com ([134.134.136.31]:10329 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750950AbeEPPji (ORCPT ); Wed, 16 May 2018 11:39:38 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,406,1520924400"; d="scan'208";a="229110476" Message-ID: <1526485176.61700.12.camel@linux.intel.com> Subject: Re: [RFC/RFT] [PATCH 03/10] cpufreq: intel_pstate: Utility functions to boost HWP performance limits From: Srinivas Pandruvada To: Peter Zijlstra , "Rafael J. Wysocki" Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Len Brown , "Rafael J. Wysocki" , Mel Gorman , the arch/x86 maintainers , Linux PM , Viresh Kumar , Juri Lelli , Linux Kernel Mailing List Date: Wed, 16 May 2018 08:39:36 -0700 In-Reply-To: <20180516104313.GC12217@hirez.programming.kicks-ass.net> References: <20180516044911.28797-1-srinivas.pandruvada@linux.intel.com> <20180516044911.28797-4-srinivas.pandruvada@linux.intel.com> <20180516072202.GV12217@hirez.programming.kicks-ass.net> <20180516104313.GC12217@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.24.6 (3.24.6-1.fc26) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2018-05-16 at 12:43 +0200, Peter Zijlstra wrote: > On Wed, May 16, 2018 at 11:15:09AM +0200, Rafael J. Wysocki wrote: > > > So if the "cached" thing is the last "not boosted EPP", that's why > > it > > is not updated here. > > Sure, I see what it does, just saying that naming and comments are > wrong > vs the actual code. I will fix in the next revision. Thanks, Srinivas