Re: [PATCH -tip v3 5/7] x86: kprobes: Ignore break_handler

Ingo Molnar
2018-05-18T06:26:44Z

* Masami Hiramatsu <mhiramat@kernel.org> wrote:

> Remove break_handler related code since that was used
> only for jprobe and jprobe is removed now.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> arch/x86/kernel/kprobes/common.h | 10 ----------
> arch/x86/kernel/kprobes/core.c | 13 ++-----------
> arch/x86/kernel/kprobes/ftrace.c | 16 ++--------------
> 3 files changed, 4 insertions(+), 35 deletions(-)

Even after this change there's a stale reference to ->break_handler():

arch/x86/include/asm/kprobes.h: * a post_handler or break_handler).

Please use 'git grep'!

Also, there's no reason to send an incomplete series: please remove _all_
->break_handler() references so that it's 100% gone! The pain of having and not
having ->break_handler() is completely unnecessary.

Thanks,

Ingo