From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752099AbeEYEYG (ORCPT ); Fri, 25 May 2018 00:24:06 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:50015 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750964AbeEYEYE (ORCPT ); Fri, 25 May 2018 00:24:04 -0400 X-UUID: 55478a20da444ded86fdfe74722c12a6-20180525 Message-ID: <1527222238.27165.12.camel@mtksdaap41> Subject: Re: [PATCH v3 4/8] drm/mediatek: add ddp component AAL1 From: CK Hu To: CC: Philipp Zabel , David Airlie , Rob Herring , Mark Rutland , Matthias Brugger , , , , , , Date: Fri, 25 May 2018 12:23:58 +0800 In-Reply-To: <1527215665-11937-5-git-send-email-stu.hsieh@mediatek.com> References: <1527215665-11937-1-git-send-email-stu.hsieh@mediatek.com> <1527215665-11937-5-git-send-email-stu.hsieh@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Stu: On Fri, 2018-05-25 at 10:34 +0800, stu.hsieh@mediatek.com wrote: > From: Stu Hsieh > > This patch add component AAL1 and > rename AAL to AAL0 > > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > index 0828cf8bf85c..eee3c0cc2632 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > @@ -41,7 +41,8 @@ enum mtk_ddp_comp_type { > }; > > enum mtk_ddp_comp_id { > - DDP_COMPONENT_AAL, > + DDP_COMPONENT_AAL0, > + DDP_COMPONENT_AAL1, Be sure compiling is success when you apply each patch of a series. I think when you apply to this patch, it would cause compiling error because some related modification is in the patch 'Add support for mediatek SOC MT2712'. So move the modification from that patch to this patch. Regards, CK > DDP_COMPONENT_BLS, > DDP_COMPONENT_COLOR0, > DDP_COMPONENT_COLOR1,