Re: [PATCH v4a 8/8] module: replace the existing LSM hook in init_module

Mimi Zohar
2018-06-05T21:35:35Z

On Tue, 2018-06-05 at 12:45 -0700, Kees Cook wrote:

> And if you must have a separate enum, please change this to fail
> closed instead of open (and mark the fall-through):
>
> int rc = -EPERM;
>
> switch (id) {
> case LOADING_MODULE:
> rc = loadpin_read_file(NULL, READING_MODULE);
> /* Fall-through */
> default:
> break;
> }

This will fail the sysfs firmware fallback loading and the kexec_load
syscall without any message, as you have for init_module.  Is that
what you want?

Mimi