From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968935AbeE3Jrl (ORCPT ); Wed, 30 May 2018 05:47:41 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:37527 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965077AbeE3Jrh (ORCPT ); Wed, 30 May 2018 05:47:37 -0400 X-Google-Smtp-Source: ADUXVKJmyjtS/phfnj7vUvvnyyeM5TIN7W8CdaRP/0F/GRd1n3FzQN/ZGCAOiZq7/BVhwSZqkdgrzg== Message-ID: <1527673654.10642.18.camel@baylibre.com> Subject: Re: [PATCH 2/2] mmc: meson-gx: add device reset From: Jerome Brunet To: Ulf Hansson Cc: Carlo Caione , Kevin Hilman , devicetree@vger.kernel.org, "open list:ARM/Amlogic Meson..." , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Corentin Labbe Date: Wed, 30 May 2018 11:47:34 +0200 In-Reply-To: References: <20180515095748.6794-1-jbrunet@baylibre.com> <20180515095748.6794-3-jbrunet@baylibre.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 (3.26.6-1.fc27) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2018-05-30 at 09:27 +0200, Ulf Hansson wrote: > Jerome, > > On 15 May 2018 at 11:57, Jerome Brunet wrote: > > Trigger the reset line of the mmc controller while probing, if available. > > The reset should be optional for now, at least until all related DT nodes > > have the reset property. > > > > Reviewed-by: Kevin Hilman > > Signed-off-by: Jerome Brunet > > I got a regression boot report from kernelci. The bisect doesn't point > to a certain commit, but I found $subject patch a possible cause. Is > it something you can have a look at and see if it's a valid problem? > https://kernelci.org/boot/id/5b0d68a859b514726179a899/ Hi Ulf, Looking at the log, there is an "un-explained" power reset in the middle of the boot sequence. With the maintainer of this lab, we have been over the logs of this board and we have seen several other power reset at different stages. There is no trace, error or warning, the board just resets. A few other boards show the same issue in this lab ATM. There has been some work done in this lab lately and we suspect a problem with the relays controlling the power supplies. We have taken this board offline until the problem is solved. Thanks for reporting the problem. Regards Jerome > > Kind regards > Uffe > > > --- > > drivers/mmc/host/meson-gx-mmc.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c > > index 4f972b879fe6..9bca359f7936 100644 > > --- a/drivers/mmc/host/meson-gx-mmc.c > > +++ b/drivers/mmc/host/meson-gx-mmc.c > > @@ -35,6 +35,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -1184,6 +1185,14 @@ static int meson_mmc_probe(struct platform_device *pdev) > > goto free_host; > > } > > > > + ret = device_reset_optional(&pdev->dev); > > + if (ret) { > > + if (ret != -EPROBE_DEFER) > > + dev_err(&pdev->dev, "device reset failed: %d\n", ret); > > + > > + return ret; > > + } > > + > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > host->regs = devm_ioremap_resource(&pdev->dev, res); > > if (IS_ERR(host->regs)) { > > -- > > 2.14.3 > >