Re: [PATCH 09/19] sched/numa: Modify migrate_swap to accept additional params

Rik van Riel
2018-06-04T17:00:23Z

[-- Attachment #1: Type: text/plain, Size: 899 bytes --]

On Mon, 2018-06-04 at 15:30 +0530, Srikar Dronamraju wrote:
> There are checks in migrate_swap_stop that check if the task/cpu
> combination is as per migrate_swap_arg before migrating.
>
> However atleast one of the two tasks to be swapped by migrate_swap
> could
> have migrated to a completely different cpu before updating the
> migrate_swap_arg. The new cpu where the task is currently running
> could
> be a different node too. If the task has migrated, numa balancer
> might
> end up placing a task in a wrong node. Instead of achieving node
> consolidation, it may end up spreading the load across nodes.
>
> To avoid that pass the cpus as additional parameters.
>
> While here, place migrate_swap under CONFIG_NUMA_BALANCING.
>
> Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

Reviewed-by: Rik van Riel <riel@surriel.com>

--
All Rights Reversed.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]