Re: [PATCH 02/19] sched/numa: Evaluate move once per node

Srikar Dronamraju
2018-06-04T15:45:31Z

* Rik van Riel <riel@surriel.com> [2018-06-04 10:51:27]:

> On Mon, 2018-06-04 at 15:30 +0530, Srikar Dronamraju wrote:
>
>
> Just bike shedding, but it may be easier to read
> if the "we found our destination" check were written
> more explicitly:
>
>
> if (!cur) {
> if (move && imp > env->best_imp)
> gote assign;
> else
> goto unlock;
> }
>

will incorporate this.

> Also, the "move" variable seems to indicate that
> the NUMA code may move the task, but not a decision
> that moving the task is better than a swap.
>
> Would it make sense to call it "maymove"?

Okay, will incorporate this too.

>
> I like how this patch simplifies the code a little.
>

Thanks.