Re: [PATCH 07/19] sched/numa: Skip nodes that are at hoplimit

Rik van Riel
2018-06-04T16:28:03Z

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

On Mon, 2018-06-04 at 15:30 +0530, Srikar Dronamraju wrote:
> When comparing two nodes at a distance of hoplimit, we should
> consider
> nodes only upto hoplimit. Currently we also consider nodes at
> hoplimit
> distance too. Hence two nodes at a distance of "hoplimit" will have
> same
> groupweight. Fix this by skipping nodes at hoplimit.

> While there is a regression with this change, this change is needed
> from a
> correctness perspective. Also it helps consolidation as seen from
> perf bench
> output.
>
> Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

Good catch.

Reviewed-by: Rik van Riel <riel@surriel.com>

--
All Rights Reversed.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]